Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 2697293003: [Mac RTL] Only tie the avatar button to the left side of the screen when it's moved to that side. (Closed)

Created:
3 years, 10 months ago by Avi (use Gerrit)
Modified:
3 years, 10 months ago
Reviewers:
erikchen
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac RTL] Only tie the avatar button to the left side of the screen when it's moved to that side. BUG=693312 TEST=as in bug Review-Url: https://codereview.chromium.org/2697293003 Cr-Commit-Position: refs/heads/master@{#451213} Committed: https://chromium.googlesource.com/chromium/src/+/d6f07b82407d19d1fc84013335b5b90bf83f4227

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Avi (use Gerrit)
3 years, 10 months ago (2017-02-17 02:56:39 UTC) #4
erikchen
3 years, 10 months ago (2017-02-17 03:31:04 UTC) #5
erikchen
lgtm
3 years, 10 months ago (2017-02-17 03:31:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697293003/1
3 years, 10 months ago (2017-02-17 04:06:57 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 04:40:04 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d6f07b82407d19d1fc84013335b5...

Powered by Google App Engine
This is Rietveld 408576698