third_party/WebKit/Source/platform/graphics/BoxReflection.h - Issue 2743363006: Clean up cc/paint interfaces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/BoxReflection.h

Issue 2743363006: Clean up cc/paint interfaces (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/BoxReflection.h

diff --git a/third_party/WebKit/Source/platform/graphics/BoxReflection.h b/third_party/WebKit/Source/platform/graphics/BoxReflection.h

index 7a6f7318886a347a5251876c2285246e73105e86..d572e82a09a118aa6ea7e8253254004f17f1c759 100644

--- a/third_party/WebKit/Source/platform/graphics/BoxReflection.h

+++ b/third_party/WebKit/Source/platform/graphics/BoxReflection.h

@@ -37,7 +37,7 @@ class PLATFORM_EXPORT BoxReflection {

ReflectionDirection direction() const { return m_direction; }

float offset() const { return m_offset; }

- PaintRecord* mask() const { return m_mask.get(); }

+ sk_sp<PaintRecord> mask() const { return m_mask; }

danakj 2017/03/16 20:06:15 const& for returning so u can mask()->thing withou

// Returns a matrix which maps points between the original content and its

// reflection. Reflections are self-inverse, so this matrix can be used to