Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 2743363003: Be shell-safe with git-filter-branch use in update.py (Closed)

Created:
3 years, 9 months ago by Mark Mentovai
Modified:
3 years, 9 months ago
Reviewers:
agable
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Be shell-safe with git-filter-branch use in update.py The command argument to git filter-branch --index-filter is always passed to a shell. Even on Windows, this will be git bash. Use proper quoting when building this argument. BUG=697185 Review-Url: https://codereview.chromium.org/2743363003 Cr-Commit-Position: refs/heads/master@{#456579} Committed: https://chromium.googlesource.com/chromium/src/+/391e842f5feab036653813d0d441c1d504a971e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/crashpad/update.py View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Mark Mentovai
3 years, 9 months ago (2017-03-13 20:32:44 UTC) #2
agable
lgtm
3 years, 9 months ago (2017-03-13 23:35:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743363003/1
3 years, 9 months ago (2017-03-14 00:11:49 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 02:21:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/391e842f5feab036653813d0d441...

Powered by Google App Engine
This is Rietveld 408576698