Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: third_party/crashpad/update.py

Issue 2743363003: Be shell-safe with git-filter-branch use in update.py (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/crashpad/update.py
diff --git a/third_party/crashpad/update.py b/third_party/crashpad/update.py
index c692c817b9ce48d328af7ff9288004b5421d1807..7781e26afd8fdb6a7aaaa060618fd1ff38a9b1cd 100755
--- a/third_party/crashpad/update.py
+++ b/third_party/crashpad/update.py
@@ -7,6 +7,7 @@
import argparse
import os
+import pipes
import re
import subprocess
import sys
@@ -131,7 +132,8 @@ def main(args):
'filter-branch',
'--force',
'--index-filter',
- 'git rm --cached --ignore-unmatch ' + ' '.join(parsed.exclude),
+ 'git rm --cached --ignore-unmatch ' +
+ ' '.join(pipes.quote(path) for path in parsed.exclude),
revision_old + '..UPDATE_TO'],
cwd=toplevel,
shell=IS_WINDOWS)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698