Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2743193002: Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in ash/ (Closed)

Created:
3 years, 9 months ago by Byoungkwon Ko
Modified:
3 years, 9 months ago
Reviewers:
Tim Song, Daniel Erat
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in ash/ BUG=644626 Review-Url: https://codereview.chromium.org/2743193002 Cr-Commit-Position: refs/heads/master@{#457327} Committed: https://chromium.googlesource.com/chromium/src/+/9e0c428878a84a2a53623ea973e761dff3c83b0c

Patch Set 1 #

Patch Set 2 : Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in ash/ #

Patch Set 3 : Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in ash/ #

Patch Set 4 : Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in ash/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ash/sticky_keys/sticky_keys_controller.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/test/shelf_button_pressed_metric_tracker_test_api.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 36 (24 generated)
Byoungkwon Ko
PTAL
3 years, 9 months ago (2017-03-12 12:10:25 UTC) #2
Tim Song
lgtm
3 years, 9 months ago (2017-03-14 01:14:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743193002/1
3 years, 9 months ago (2017-03-14 01:16:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/298210) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 9 months ago (2017-03-14 01:23:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743193002/60001
3 years, 9 months ago (2017-03-14 10:00:13 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/384776)
3 years, 9 months ago (2017-03-14 10:07:27 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743193002/60001
3 years, 9 months ago (2017-03-14 10:31:17 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/384790)
3 years, 9 months ago (2017-03-14 10:38:41 UTC) #28
Byoungkwon Ko
PTAL
3 years, 9 months ago (2017-03-15 04:47:18 UTC) #30
Daniel Erat
lgtm
3 years, 9 months ago (2017-03-15 14:54:33 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743193002/60001
3 years, 9 months ago (2017-03-16 01:31:34 UTC) #33
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 02:43:58 UTC) #36
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9e0c428878a84a2a53623ea973e7...

Powered by Google App Engine
This is Rietveld 408576698