|
|
Chromium Code Reviews|
Created:
3 years, 9 months ago by Byoungkwon Ko Modified:
3 years, 9 months ago CC:
chromium-reviews, kalyank, sadrul Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionReplace unique_ptr.reset(other_unique_ptr.release()) with std::move() in ash/
BUG=644626
Review-Url: https://codereview.chromium.org/2743193002
Cr-Commit-Position: refs/heads/master@{#457327}
Committed: https://chromium.googlesource.com/chromium/src/+/9e0c428878a84a2a53623ea973e761dff3c83b0c
Patch Set 1 #Patch Set 2 : Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in ash/ #Patch Set 3 : Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in ash/ #Patch Set 4 : Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in ash/ #
Messages
Total messages: 36 (24 generated)
gogag2@gmail.com changed reviewers: + tengs@chromium.org
PTAL
lgtm
The CQ bit was checked by gogag2@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by gogag2@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by gogag2@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by gogag2@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by gogag2@gmail.com
The patchset sent to the CQ was uploaded after l-g-t-m from tengs@chromium.org Link to the patchset: https://codereview.chromium.org/2743193002/#ps60001 (title: "Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in ash/")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by gogag2@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
gogag2@gmail.com changed reviewers: + derat@chromium.org
PTAL
lgtm
The CQ bit was checked by gogag2@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489627872308990,
"parent_rev": "5d5c1c5c6d96ba9431897acd2a0eea2a2eabcac2", "commit_rev":
"9e0c428878a84a2a53623ea973e761dff3c83b0c"}
Message was sent while issue was closed.
Description was changed from ========== Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in ash/ BUG=644626 ========== to ========== Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in ash/ BUG=644626 Review-Url: https://codereview.chromium.org/2743193002 Cr-Commit-Position: refs/heads/master@{#457327} Committed: https://chromium.googlesource.com/chromium/src/+/9e0c428878a84a2a53623ea973e7... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/9e0c428878a84a2a53623ea973e7... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
