ash/sticky_keys/sticky_keys_controller.cc - Issue 2743193002: Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in ash/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/sticky_keys/sticky_keys_controller.cc

Issue 2743193002: Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in ash/ (Closed)

Patch Set: Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in ash/ Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/sticky_keys/sticky_keys_controller.cc

diff --git a/ash/sticky_keys/sticky_keys_controller.cc b/ash/sticky_keys/sticky_keys_controller.cc

index d3257a8adbe291f4094708eaea93a86d27b6e030..29706f8f89b2a2f6c8f8e44ade18f5c2daba1185 100644

--- a/ash/sticky_keys/sticky_keys_controller.cc

+++ b/ash/sticky_keys/sticky_keys_controller.cc

@@ -295,7 +295,7 @@ int StickyKeysHandler::GetModifierUpEvent(

DCHECK(new_event);

if (*new_event)

return 1;

- new_event->reset(modifier_up_event_.release());

+ *new_event = std::move(modifier_up_event_);

return 0;

}

« no previous file with comments | « no previous file | ash/test/shelf_button_pressed_metric_tracker_test_api.cc » ('j') | no next file with comments »