Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Issue 2743113003: Stop passing "force" option when invoking cros-disks's Unmount method. (Closed)

Created:
3 years, 9 months ago by Ben Chan
Modified:
3 years, 9 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, oshima+watch_chromium.org, hashimoto+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop passing "force" option when invoking cros-disks's Unmount method. cros-disks's Unmount method now ignores the "force" option (CL:388592, chromium:646224). This CL updates CrosDisksClient to stop passing the "force" option when invoking the Unmount method. BUG=700548 TEST=chromos_unittests Review-Url: https://codereview.chromium.org/2743113003 Cr-Commit-Position: refs/heads/master@{#456230} Committed: https://chromium.googlesource.com/chromium/src/+/8bcaea14967dab3bbfd0a13ccbb567c70614f149

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M chromeos/dbus/cros_disks_client.cc View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Ben Chan
3 years, 9 months ago (2017-03-10 23:29:41 UTC) #7
stevenjb
owner lgtm
3 years, 9 months ago (2017-03-10 23:59:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743113003/1
3 years, 9 months ago (2017-03-11 00:21:27 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-11 00:27:38 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8bcaea14967dab3bbfd0a13ccbb5...

Powered by Google App Engine
This is Rietveld 408576698