Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chromeos/dbus/cros_disks_client.cc

Issue 2743113003: Stop passing "force" option when invoking cros-disks's Unmount method. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/cros_disks_client.cc
diff --git a/chromeos/dbus/cros_disks_client.cc b/chromeos/dbus/cros_disks_client.cc
index 47f961d3cca084115b00520d142c4fbc5b7b755c..42ed90ee9c1b88f776e0d1640c315df18ca9d9e6 100644
--- a/chromeos/dbus/cros_disks_client.cc
+++ b/chromeos/dbus/cros_disks_client.cc
@@ -40,10 +40,6 @@ const char kReadWriteOption[] = "rw";
const char kRemountOption[] = "remount";
const char kMountLabelOption[] = "mountlabel";
-const char* kDefaultUnmountOptions[] = {
- "force",
-};
-
const char kLazyUnmountOption[] = "lazy";
// Checks if retrieved media type is in boundaries of DeviceMediaType.
@@ -133,9 +129,7 @@ class CrosDisksClientImpl : public CrosDisksClient {
dbus::MessageWriter writer(&method_call);
writer.AppendString(device_path);
- std::vector<std::string> unmount_options(
- kDefaultUnmountOptions,
- kDefaultUnmountOptions + arraysize(kDefaultUnmountOptions));
+ std::vector<std::string> unmount_options;
if (options == UNMOUNT_OPTIONS_LAZY)
unmount_options.push_back(kLazyUnmountOption);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698