Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2743023002: Migrate WTF::Deque::append() to ::push_back() (Closed)

Created:
3 years, 9 months ago by pilgrim_google
Modified:
3 years, 9 months ago
CC:
Mads Ager (chromium), ajuma+watch_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-wtf_chromium.org, blink-worker-reviews_chromium.org, Rik, caseq+blink_chromium.org, chromium-reviews, danakj+watch_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, dtapuska+blinkwatch_chromium.org, eae+blinkwatch, eric.carlson_apple.com, falken+watch_chromium.org, feature-media-reviews_chromium.org, feature-vr-reviews_chromium.org, fmalita+watch_chromium.org, groby+blinkspell_chromium.org, horo+watch_chromium.org, jbroman, Justin Novosad, kinuko+watch, kinuko+fileapi, kinuko+worker_chromium.org, kouhei+heap_chromium.org, kozyatinskiy+blink_chromium.org, loading-reviews+parser_chromium.org, lushnikov+blink_chromium.org, Mikhail, mlamouri+watch-blink_chromium.org, nhiroki, Navid Zolghadr, oilpan-reviews, pdr+graphicswatchlist_chromium.org, pfeldman+blink_chromium.org, piman+watch_chromium.org, rwlbuis, Stephen Chennney, shimazu+worker_chromium.org, sof, Srirama, timvolodine, tyoshino+watch_chromium.org, tzik, yhirano+watch_chromium.org, jsbell
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WTF::Deque::append() to ::push_back() As discussed on platform-architecture-dev [0], there is interest in normalizing the methods of WTF classes to better align with std classes. There are no functional changes. [0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion BUG=662431 Review-Url: https://codereview.chromium.org/2743023002 Cr-Commit-Position: refs/heads/master@{#456397} Committed: https://chromium.googlesource.com/chromium/src/+/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -153 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontFace.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Fullscreen.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunner.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/UndoStack.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameSerializer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/FormController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/PointerEventManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/DOMPatchSupport.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTaskRunner.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp View 8 chunks +12 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/BytesConsumer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/BytesConsumerTestUtil.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/speech/testing/PlatformSpeechSynthesizerMock.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VRController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/Database.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLTransactionBackend.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLTransactionCoordinator.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp View 6 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/ScriptRunIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/SharedContextRateLimiter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 12 chunks +29 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/platform/text/SegmentedString.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/Deque.h View 3 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/wtf/DequeTest.cpp View 16 chunks +32 lines, -32 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
pilgrim_google
3 years, 9 months ago (2017-03-10 16:28:54 UTC) #3
haraken
LGTM
3 years, 9 months ago (2017-03-10 19:14:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743023002/1
3 years, 9 months ago (2017-03-10 20:54:22 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/383153)
3 years, 9 months ago (2017-03-10 21:02:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743023002/20001
3 years, 9 months ago (2017-03-13 14:27:36 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 16:32:24 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2c5d87086fe766b96f9e35cbd94b...

Powered by Google App Engine
This is Rietveld 408576698