third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h - Issue 2743023002: Migrate WTF::Deque::append() to ::push_back()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h

Issue 2743023002: Migrate WTF::Deque::append() to ::push_back() (Closed)

Patch Set: rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp ('k') | third_party/WebKit/Source/core/css/CSSFontFace.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h

index aebeafdfc708d53e37058dda313c24bb64e38001..a8763a8eeb07fc6b387d303ec8a469b38e74f240 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h

@@ -172,11 +172,11 @@ class CORE_EXPORT ScriptWrappableVisitor : public v8::EmbedderHeapTracer,

if (!m_tracingInProgress)

return false;

- m_markingDeque.append(WrapperMarkingData(traceWrappersCallback,

- heapObjectHeaderCallback, object));

+ m_markingDeque.push_back(WrapperMarkingData(

+ traceWrappersCallback, heapObjectHeaderCallback, object));

#if DCHECK_IS_ON()

if (!m_advancingTracing) {

- m_verifierDeque.append(WrapperMarkingData(

+ m_verifierDeque.push_back(WrapperMarkingData(

traceWrappersCallback, heapObjectHeaderCallback, object));

}

#endif