Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 2742973002: Migrate two std::remove_if usages to use base::EraseIf instead (Closed)

Created:
3 years, 9 months ago by Peter Beverloo
Modified:
3 years, 9 months ago
Reviewers:
Miguel Garcia
CC:
chromium-reviews, awdf+watch_chromium.org, Peter Beverloo, mlamouri+watch-notifications_chromium.org, jam, raymes+watch_chromium.org, darin-cc_chromium.org, mlamouri+watch-permissions_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate two std::remove_if usages to use base::EraseIf instead BUG= Review-Url: https://codereview.chromium.org/2742973002 Cr-Commit-Position: refs/heads/master@{#456056} Committed: https://chromium.googlesource.com/chromium/src/+/b4db19ff1260511b90e14cde6ddf251a1c77cfa9

Patch Set 1 #

Patch Set 2 : Merge thing 2742973002 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M chrome/browser/notifications/notification_permission_context.cc View 1 2 chunks +2 lines, -5 lines 0 comments Download
M content/browser/notifications/platform_notification_context_impl.cc View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (12 generated)
Miguel Garcia
lgtm
3 years, 9 months ago (2017-03-10 13:50:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742973002/20001
3 years, 9 months ago (2017-03-10 14:18:00 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 14:22:46 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b4db19ff1260511b90e14cde6ddf...

Powered by Google App Engine
This is Rietveld 408576698