Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1773)

Unified Diff: chrome/browser/notifications/notification_permission_context.cc

Issue 2742973002: Migrate two std::remove_if usages to use base::EraseIf instead (Closed)
Patch Set: Merge thing 2742973002 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/notifications/platform_notification_context_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/notifications/notification_permission_context.cc
diff --git a/chrome/browser/notifications/notification_permission_context.cc b/chrome/browser/notifications/notification_permission_context.cc
index 36c6d91541b9047087e8aaa7813b17ab056b6206..3d3f0830d03fb4eefb4b0829cbb0a679047e27bb 100644
--- a/chrome/browser/notifications/notification_permission_context.cc
+++ b/chrome/browser/notifications/notification_permission_context.cc
@@ -4,13 +4,13 @@
#include "chrome/browser/notifications/notification_permission_context.h"
-#include <algorithm>
#include <deque>
#include "base/callback.h"
#include "base/location.h"
#include "base/rand_util.h"
#include "base/single_thread_task_runner.h"
+#include "base/stl_util.h"
#include "base/threading/thread_task_runner_handle.h"
#include "base/timer/timer.h"
#include "chrome/browser/notifications/desktop_notification_profile_util.h"
@@ -122,10 +122,7 @@ void VisibilityTimerTabHelper::PostTaskAfterVisibleDelay(
void VisibilityTimerTabHelper::CancelTask(const PermissionRequestID& id) {
bool deleting_front = task_queue_.front().id == id;
- task_queue_.erase(
- std::remove_if(task_queue_.begin(), task_queue_.end(),
- [id](const Task& task) { return task.id == id; }),
- task_queue_.end());
+ base::EraseIf(task_queue_, [id](const Task& task) { return task.id == id; });
if (!task_queue_.empty() && is_visible_ && deleting_front)
task_queue_.front().timer->Reset();
« no previous file with comments | « no previous file | content/browser/notifications/platform_notification_context_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698