Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issue 2742933002: Refactor determineRequestContext() to remove a mutableResourceRequest() call (Closed)

Created:
3 years, 9 months ago by hiroshige
Modified:
3 years, 9 months ago
Reviewers:
Nate Chapin
CC:
chromium-reviews, Yoav Weiss, gavinp+prerender_chromium.org, blink-reviews-html_chromium.org, loading-reviews+parser_chromium.org, loading-reviews_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin, tyoshino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor determineRequestContext() to remove a mutableResourceRequest() This CL removes a mutable reference to ResourceRequest in the argument of ResourceFetcher::determineRequestContext(), to reduce mutableResourceRequest() call. BUG=632580 Review-Url: https://codereview.chromium.org/2742933002 Cr-Commit-Position: refs/heads/master@{#456213} Committed: https://chromium.googlesource.com/chromium/src/+/77a7705fdb732061ad523782e41049b4e2e6fe1e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -24 lines) Patch
M third_party/WebKit/Source/core/html/parser/PreloadRequest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/resource/LinkFetchResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp View 3 chunks +7 lines, -15 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
hiroshige
PTAL.
3 years, 9 months ago (2017-03-10 20:13:07 UTC) #7
Nate Chapin
lgtm
3 years, 9 months ago (2017-03-10 20:15:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742933002/1
3 years, 9 months ago (2017-03-10 23:12:42 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 23:18:17 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/77a7705fdb732061ad523782e410...

Powered by Google App Engine
This is Rietveld 408576698