Remove mutableResourceRequest() by FetchRequest::setRequestContext()

Remove mutableResourceRequest() by FetchRequest::setRequestContext()

It is common that FooResource::fetch()-like functions sets
the request context via mutableResourceRequest().
This CL centralizes such mutableResourceRequest() calls into newly
introduced FetchRequest::setRequestContext(), to limit the ways to
modify a ResourceRequest after it is put in a FetchRequest.

BUG=632580
Review-Url: https://codereview.chromium.org/2741753003
Cr-Commit-Position: refs/heads/master@{#456208}
Committed: https://chromium.googlesource.com/chromium/src/+/b3adecaccaaa4c19f3a94be273e813d81b357a99

[hiroshige, 2017-03-10 01:35:59]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 01:36:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 02:56:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 02:56:40]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2017-03-10 20:07:47]

Description was changed from

==========
Remove mutableResourceRequest() in fetch()-like functions

BUG=
==========

to

==========
Remove mutableResourceRequest() by FetchRequest::setRequestContext()

It is common that FooResource::fetch()-like functions sets
the request context via mutableResourceRequest().
This CL centralizes such mutableResourceRequest() calls into newly
introduced FetchRequest::setRequestContext().

BUG=632580
==========

[hiroshige, 2017-03-10 20:07:47]

hiroshige@chromium.org changed reviewers:
+ japhet@chromium.org

[hiroshige, 2017-03-10 20:07:51]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[hiroshige, 2017-03-10 20:07:59]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[hiroshige, 2017-03-10 20:08:09]

PTAL.

[commit-bot: I haz the power, 2017-03-10 20:08:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nate Chapin, 2017-03-10 20:16:56]

LGTM, but it might be worth noting in the CL description that this is with the
goal of having this be the only(?) way to modify a ResourceRequest after it is
put in a FetchRequest.

[hiroshige, 2017-03-10 20:59:34]

Description was changed from

==========
Remove mutableResourceRequest() by FetchRequest::setRequestContext()

It is common that FooResource::fetch()-like functions sets
the request context via mutableResourceRequest().
This CL centralizes such mutableResourceRequest() calls into newly
introduced FetchRequest::setRequestContext().

BUG=632580
==========

to

==========
Remove mutableResourceRequest() by FetchRequest::setRequestContext()

It is common that FooResource::fetch()-like functions sets
the request context via mutableResourceRequest().
This CL centralizes such mutableResourceRequest() calls into newly
introduced FetchRequest::setRequestContext(), to limit the ways to
modify a ResourceRequest after it is put in a FetchRequest.

BUG=632580
==========

[hiroshige, 2017-03-10 21:03:30]

On 2017/03/10 20:16:56, Nate Chapin wrote:
> LGTM, but it might be worth noting in the CL description that this is with the
> goal of having this be the only(?) way to modify a ResourceRequest after it is
> put in a FetchRequest.

Done.
There would still be several ways to modify a ResourceRequest via FetchRequest
(not 
"the only"), but in a more restricted ways (e.g. except for those in
ResourceFetcher/FetchFrameContext, modifications would be only by
FetchRequest::setRequestContext() or a couple of exceptional paths).

[hiroshige, 2017-03-10 21:56:52]

The CQ bit was unchecked by hiroshige@chromium.org

[hiroshige, 2017-03-10 21:56:55]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2017-03-10 21:57:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 23:09:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489183015605070,
"parent_rev": "fd95cbb906c7144c7e3396296791f6c1e0e5fc58", "commit_rev":
"b3adecaccaaa4c19f3a94be273e813d81b357a99"}

[commit-bot: I haz the power, 2017-03-10 23:10:39]

Description was changed from

==========
Remove mutableResourceRequest() by FetchRequest::setRequestContext()

It is common that FooResource::fetch()-like functions sets
the request context via mutableResourceRequest().
This CL centralizes such mutableResourceRequest() calls into newly
introduced FetchRequest::setRequestContext(), to limit the ways to
modify a ResourceRequest after it is put in a FetchRequest.

BUG=632580
==========

to

==========
Remove mutableResourceRequest() by FetchRequest::setRequestContext()

It is common that FooResource::fetch()-like functions sets
the request context via mutableResourceRequest().
This CL centralizes such mutableResourceRequest() calls into newly
introduced FetchRequest::setRequestContext(), to limit the ways to
modify a ResourceRequest after it is put in a FetchRequest.

BUG=632580

Review-Url: https://codereview.chromium.org/2741753003
Cr-Commit-Position: refs/heads/master@{#456208}
Committed:
https://chromium.googlesource.com/chromium/src/+/b3adecaccaaa4c19f3a94be273e8...
==========

[commit-bot: I haz the power, 2017-03-10 23:10:42]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b3adecaccaaa4c19f3a94be273e8...