Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Issue 2742763002: Clean up Cloud Print API flow code. (Closed)

Created:
3 years, 9 months ago by Lei Zhang
Modified:
3 years, 8 months ago
Reviewers:
rbpotter
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up Cloud Print API flow code. Simplify code, remove dead code, fix nits. Review-Url: https://codereview.chromium.org/2742763002 Cr-Commit-Position: refs/heads/master@{#460435} Committed: https://chromium.googlesource.com/chromium/src/+/74c9463920f15cebcf2e90ba5a6b613fc03bcdd8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -64 lines) Patch
M chrome/browser/printing/cloud_print/cloud_print_printer_list.h View 2 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_printer_list.cc View 2 chunks +5 lines, -15 lines 0 comments Download
M chrome/browser/printing/cloud_print/gcd_api_flow.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/printing/cloud_print/gcd_api_flow.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/printing/cloud_print/gcd_api_flow_impl.h View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/printing/cloud_print/gcd_api_flow_impl.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/printing/cloud_print/privet_confirm_api_flow.h View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/printing/cloud_print/privet_confirm_api_flow.cc View 3 chunks +3 lines, -16 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Lei Zhang
3 years, 8 months ago (2017-03-29 01:44:39 UTC) #6
rbpotter
On 2017/03/29 01:44:39, Lei Zhang wrote: lgtm
3 years, 8 months ago (2017-03-29 02:23:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742763002/1
3 years, 8 months ago (2017-03-29 03:03:54 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder ...
3 years, 8 months ago (2017-03-29 05:05:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742763002/1
3 years, 8 months ago (2017-03-29 17:11:02 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 17:23:08 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/74c9463920f15cebcf2e90ba5a6b...

Powered by Google App Engine
This is Rietveld 408576698