Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2073)

Unified Diff: chrome/browser/printing/cloud_print/cloud_print_printer_list.h

Issue 2742763002: Clean up Cloud Print API flow code. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/printing/cloud_print/cloud_print_printer_list.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/cloud_print/cloud_print_printer_list.h
diff --git a/chrome/browser/printing/cloud_print/cloud_print_printer_list.h b/chrome/browser/printing/cloud_print/cloud_print_printer_list.h
index abfadf5eb7aed795ea5d14cb53ebb79fd17683a0..f06a0c777f31558b071ed0d2c471a7098b92d32c 100644
--- a/chrome/browser/printing/cloud_print/cloud_print_printer_list.h
+++ b/chrome/browser/printing/cloud_print/cloud_print_printer_list.h
@@ -16,14 +16,11 @@ namespace cloud_print {
class CloudPrintPrinterList : public CloudPrintApiFlowRequest {
public:
struct Device {
- Device();
- ~Device();
-
std::string id;
std::string display_name;
std::string description;
};
- typedef std::vector<Device> DeviceList;
+ using DeviceList = std::vector<Device>;
class Delegate {
public:
@@ -37,17 +34,16 @@ class CloudPrintPrinterList : public CloudPrintApiFlowRequest {
explicit CloudPrintPrinterList(Delegate* delegate);
~CloudPrintPrinterList() override;
+ // CloudPrintApiFlowRequest implementation:
void OnGCDApiFlowError(GCDApiFlow::Status status) override;
-
void OnGCDApiFlowComplete(const base::DictionaryValue& value) override;
-
GURL GetURL() override;
private:
bool FillPrinterDetails(const base::DictionaryValue& printer_value,
Device* printer_details);
- Delegate* delegate_;
+ Delegate* const delegate_;
};
} // namespace cloud_print
« no previous file with comments | « no previous file | chrome/browser/printing/cloud_print/cloud_print_printer_list.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698