Make SpellChecker::clearMisspellingsForMovingParagraphs() to take SelectionInDOMTree

Make SpellChecker::clearMisspellingsForMovingParagraphs() to take SelectionInDOMTree

This patch makes |SpellChecker::clearMisspellingsForMovingParagraphs| to take
|SelectionInDOMTree| instead of |VisibleSelection| as a preparation of reducing
usage of |VisibleSelection| for improving code health.

BUG=657237
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2742753002
Cr-Commit-Position: refs/heads/master@{#455940}
Committed: https://chromium.googlesource.com/chromium/src/+/337642ea1516b47bd972b0f980a0a71b19931dd2

[yosin_UTC9, 2017-03-09 09:29:03]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 09:29:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-03-09 11:27:32]

Description was changed from

==========
Make SpellChecker::clearMisspellingsForMovingParagraphs() to take
SelectionInDOMTree

2017-03-09T18:24:25

BUG=657237
==========

to

==========
Make SpellChecker::clearMisspellingsForMovingParagraphs() to take
SelectionInDOMTree

This patch makes |SpellChecker::clearMisspellingsForMovingParagraphs| to take
|SelectionInDOMTree| instead of |VisibleSelection| as a preparation of reducing
usage of |VisibleSelection| for improving code health.

BUG=657237
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-03-09 11:28:42]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-03-09 11:28:43]

PTAL

[commit-bot: I haz the power, 2017-03-09 12:32:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 12:32:46]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-03-09 19:14:23]

lgtm

https://codereview.chromium.org/2742753002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp (right):

https://codereview.chromium.org/2742753002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:324:
createVisibleSelection(movingSelection).toNormalizedEphemeralRange(),
Is there any way to get rid of this canonicalization?

[yosin_UTC9, 2017-03-10 00:58:00]

https://codereview.chromium.org/2742753002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp (right):

https://codereview.chromium.org/2742753002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:324:
createVisibleSelection(movingSelection).toNormalizedEphemeralRange(),
On 2017/03/09 at 19:14:23, Xiaocheng wrote:
> Is there any way to get rid of this canonicalization?
I guess we can use VS::start/end here.
Or, we get rid of this function at all.
Caller remove selection passed this function after this call.
Markers should remove by node removal.

I file an issue crbug.com/700217 We should get rid of
SpellChecker::clearMisspellingsForMovingParagraphs()

[yosin_UTC9, 2017-03-10 00:58:02]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-03-10 00:58:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 01:09:17]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489107482404310, "parent_rev":
"3e39b18a5d17a997976bbaa1d6fa2de2e5c1bf6a", "commit_rev":
"337642ea1516b47bd972b0f980a0a71b19931dd2"}

[commit-bot: I haz the power, 2017-03-10 01:14:05]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489107482404310, "parent_rev":
"3e39b18a5d17a997976bbaa1d6fa2de2e5c1bf6a", "commit_rev":
"337642ea1516b47bd972b0f980a0a71b19931dd2"}

[commit-bot: I haz the power, 2017-03-10 01:14:09]

Description was changed from

==========
Make SpellChecker::clearMisspellingsForMovingParagraphs() to take
SelectionInDOMTree

This patch makes |SpellChecker::clearMisspellingsForMovingParagraphs| to take
|SelectionInDOMTree| instead of |VisibleSelection| as a preparation of reducing
usage of |VisibleSelection| for improving code health.

BUG=657237
TEST=n/a; no behavior changes
==========

to

==========
Make SpellChecker::clearMisspellingsForMovingParagraphs() to take
SelectionInDOMTree

This patch makes |SpellChecker::clearMisspellingsForMovingParagraphs| to take
|SelectionInDOMTree| instead of |VisibleSelection| as a preparation of reducing
usage of |VisibleSelection| for improving code health.

BUG=657237
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2742753002
Cr-Commit-Position: refs/heads/master@{#455940}
Committed:
https://chromium.googlesource.com/chromium/src/+/337642ea1516b47bd972b0f980a0...
==========

[commit-bot: I haz the power, 2017-03-10 01:14:10]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/337642ea1516b47bd972b0f980a0...