Make SpellChecker::clearMisspellingsForMovingParagraphs() to take SelectionInDOMTree

third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 301 matching lines @@
   if (spellCheckerClient().spellingUIIsShowing()) {
     spellCheckerClient().showSpellingUI(false);
     return;
   }
 
   advanceToNextMisspelling(true);
   spellCheckerClient().showSpellingUI(true);
 }
 
 void SpellChecker::clearMisspellingsForMovingParagraphs(
-    const VisibleSelection& movingSelection) {
-  removeMarkers(movingSelection.toNormalizedEphemeralRange(),
-                DocumentMarker::MisspellingMarkers());
+    const SelectionInDOMTree& movingSelection) {
+  removeMarkers(
+      createVisibleSelection(movingSelection).toNormalizedEphemeralRange(),

[Xiaocheng, 2017/03/09 19:14:23]

Is there any way to get rid of this canonicalization?

[yosin_UTC9, 2017/03/10 00:58:00]

I guess we can use VS::start/end here.
Or, we get rid of this function at all.
Caller remove selection passed this function after this call.
Markers should remove by node removal.

I file an issue crbug.com/700217 We should get rid of
SpellChecker::clearMisspellingsForMovingParagraphs()

+      DocumentMarker::MisspellingMarkers());
 }
 
 void SpellChecker::markMisspellingsForMovingParagraphs(
     const VisibleSelection& movingSelection) {
   if (RuntimeEnabledFeatures::idleTimeSpellCheckingEnabled())
     return;
 
   // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
   // needs to be audited.  See http://crbug.com/590369 for more details.
   // In the long term we should use idle time spell checker to prevent
@@ skipping 854 matching lines @@
       if (!input.isFocusedElementInDocument())
         return false;
     }
   }
   HTMLElement* element =
       Traversal<HTMLElement>::firstAncestorOrSelf(*position.anchorNode());
   return element && element->isSpellCheckingEnabled();
 }
 
 }  // namespace blink