Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2742713002: Revert of Finish OSMesa support for Ozone X11. (Closed)

Created:
3 years, 9 months ago by Ken Rockot(use gerrit already)
Modified:
3 years, 9 months ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org, rjkroege, capn
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Finish OSMesa support for Ozone X11. (patchset #2 id:40001 of https://codereview.chromium.org/2730993002/ ) Reason for revert: Sorry, speculatively reverting based on persistent ozone builder flake. Started with this CL as best as I can tell. Appears to be a sync command buffer IPC hang on shutdown, affecting only tests which force single-process mode. Possibly a deadlock caused by ... something in the OSMesa/X11? https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux%2Flinux_chromium_chromeos_ozone_rel_ng%2F336922%2F%2B%2Frecipes%2Fsteps%2Fcontent_browsertests__with_patch_%2F0%2Flogs%2FSavableResourcesTest.GetSavableResourceLinksWithPageHasInvalidLinks%2F0 Original issue's description: > Finish OSMesa support for Ozone X11. > > Modify the GLOzone implementation for Ozone X11 OSMesa to use > GLSurfaceOSMesaX11. This copies the bitmap that OSMesa generated to the > XWindow so it's visible. > > BUG=698780 > > Review-Url: https://codereview.chromium.org/2730993002 > Cr-Commit-Position: refs/heads/master@{#455306} > Committed: https://chromium.googlesource.com/chromium/src/+/1df13216e40fed4c8fa2531fc4c764eca1aae018 TBR=kbr@chromium.org,kylechar@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=698780 Review-Url: https://codereview.chromium.org/2742713002 Cr-Commit-Position: refs/heads/master@{#455684} Committed: https://chromium.googlesource.com/chromium/src/+/657417b738a5c9c9f9d676d20b2bfdc22d660b9e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -27 lines) Patch
M ui/gl/BUILD.gn View 6 chunks +6 lines, -6 lines 0 comments Download
M ui/ozone/platform/x11/x11_surface_factory.cc View 3 chunks +1 line, -21 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Ken Rockot(use gerrit already)
Created Revert of Finish OSMesa support for Ozone X11.
3 years, 9 months ago (2017-03-09 05:58:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742713002/1
3 years, 9 months ago (2017-03-09 05:58:37 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 07:07:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/657417b738a5c9c9f9d676d20b2b...

Powered by Google App Engine
This is Rietveld 408576698