Finish OSMesa support for Ozone X11.

Finish OSMesa support for Ozone X11.

Modify the GLOzone implementation for Ozone X11 OSMesa to use
GLSurfaceOSMesaX11. This copies the bitmap that OSMesa generated to the
XWindow so it's visible.

BUG=698780
Review-Url: https://codereview.chromium.org/2730993002
Cr-Commit-Position: refs/heads/master@{#455306}
Committed: https://chromium.googlesource.com/chromium/src/+/1df13216e40fed4c8fa2531fc4c764eca1aae018

[kylechar, 2017-03-03 19:20:05]

Description was changed from

==========
Finish OSMesa support for Ozone X11.

Modify the GLOzone implementation for Ozone X11 to use
GLSurfaceOSMesaX11. This copies the contents that OSMesa has renderer to
the XWindow and makes OSMesa support for Ozone X11 work.

BUG=643368
==========

to

==========
Finish OSMesa support for Ozone X11.

Modify the GLOzone implementation for Ozone X11 OSMesa to use
GLSurfaceOSMesaX11. This copies the bitmap that OSMesa generated to the
XWindow so it's visible.

BUG=643368
==========

[kylechar, 2017-03-03 19:46:43]

Patchset #2 (id:20001) has been deleted

[kylechar, 2017-03-03 19:47:46]

kylechar@chromium.org changed reviewers:
+ kbr@chromium.org

[kylechar, 2017-03-03 19:48:24]

Description was changed from

==========
Finish OSMesa support for Ozone X11.

Modify the GLOzone implementation for Ozone X11 OSMesa to use
GLSurfaceOSMesaX11. This copies the bitmap that OSMesa generated to the
XWindow so it's visible.

BUG=643368
==========

to

==========
Finish OSMesa support for Ozone X11.

Modify the GLOzone implementation for Ozone X11 OSMesa to use
GLSurfaceOSMesaX11. This copies the bitmap that OSMesa generated to the
XWindow so it's visible.

BUG=643368
==========

[Ken Russell (switch to Gerrit), 2017-03-03 22:07:34]

LGTM

We'll want to replace this with SwiftShader ASAP. CC'ing capn@ and sugoi@ so
that you're all in sync.

[kylechar, 2017-03-04 04:29:13]

On 2017/03/03 22:07:34, Ken Russell wrote:
> LGTM
> 
> We'll want to replace this with SwiftShader ASAP. CC'ing capn@ and sugoi@ so
> that you're all in sync.

Thanks. I'm looking the kGLImplementationSwiftShaderGL implementation in
gl_initializer_x11.cc and gl_factory_x11.cc. I don't fully understand the
difference between the kGLImplementationEGLGLES2 and
kGLImplementationSwiftShaderGL paths but I'll reach out to capn/sugoi to make
sure Ozone X11 has the implementation as regular X11.

[kylechar, 2017-03-04 04:29:29]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-04 04:29:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kylechar, 2017-03-04 04:30:43]

Description was changed from

==========
Finish OSMesa support for Ozone X11.

Modify the GLOzone implementation for Ozone X11 OSMesa to use
GLSurfaceOSMesaX11. This copies the bitmap that OSMesa generated to the
XWindow so it's visible.

BUG=643368
==========

to

==========
Finish OSMesa support for Ozone X11.

Modify the GLOzone implementation for Ozone X11 OSMesa to use
GLSurfaceOSMesaX11. This copies the bitmap that OSMesa generated to the
XWindow so it's visible.

BUG=664570
==========

[commit-bot: I haz the power, 2017-03-04 05:10:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-04 05:10:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sugoi1, 2017-03-05 14:17:05]

On 2017/03/04 04:29:13, kylechar wrote:
> On 2017/03/03 22:07:34, Ken Russell wrote:
> > LGTM
> > 
> > We'll want to replace this with SwiftShader ASAP. CC'ing capn@ and sugoi@ so
> > that you're all in sync.
> 
> Thanks. I'm looking the kGLImplementationSwiftShaderGL implementation in
> gl_initializer_x11.cc and gl_factory_x11.cc. I don't fully understand the
> difference between the kGLImplementationEGLGLES2 and
> kGLImplementationSwiftShaderGL paths but I'll reach out to capn/sugoi to make
> sure Ozone X11 has the implementation as regular X11.

It's the same as regular EGL, except it loads the SwiftShader libraries instead
of the Angle libraries. Both are implementations of the libEGL and libGLESv2
libraries.

[kylechar, 2017-03-06 20:34:31]

On 2017/03/05 14:17:05, sugoi1 wrote:
> On 2017/03/04 04:29:13, kylechar wrote:
> > On 2017/03/03 22:07:34, Ken Russell wrote:
> > > LGTM
> > > 
> > > We'll want to replace this with SwiftShader ASAP. CC'ing capn@ and sugoi@
so
> > > that you're all in sync.
> > 
> > Thanks. I'm looking the kGLImplementationSwiftShaderGL implementation in
> > gl_initializer_x11.cc and gl_factory_x11.cc. I don't fully understand the
> > difference between the kGLImplementationEGLGLES2 and
> > kGLImplementationSwiftShaderGL paths but I'll reach out to capn/sugoi to
make
> > sure Ozone X11 has the implementation as regular X11.
> 
> It's the same as regular EGL, except it loads the SwiftShader libraries
instead
> of the Angle libraries. Both are implementations of the libEGL and libGLESv2
> libraries.

Good to know. That will be relatively easy to add for Ozone X11 then.

[kylechar, 2017-03-06 20:35:55]

Description was changed from

==========
Finish OSMesa support for Ozone X11.

Modify the GLOzone implementation for Ozone X11 OSMesa to use
GLSurfaceOSMesaX11. This copies the bitmap that OSMesa generated to the
XWindow so it's visible.

BUG=664570
==========

to

==========
Finish OSMesa support for Ozone X11.

Modify the GLOzone implementation for Ozone X11 OSMesa to use
GLSurfaceOSMesaX11. This copies the bitmap that OSMesa generated to the
XWindow so it's visible.

BUG=698780
==========

[kylechar, 2017-03-07 20:57:46]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 20:58:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kylechar, 2017-03-07 21:36:12]

The CQ bit was unchecked by kylechar@chromium.org

[kylechar, 2017-03-07 21:36:12]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2017-03-07 21:36:28]

The CQ bit was unchecked by kylechar@chromium.org

[commit-bot: I haz the power, 2017-03-07 21:36:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kylechar, 2017-03-08 00:08:11]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2017-03-08 00:08:19]

The CQ bit was unchecked by kylechar@chromium.org

[kylechar, 2017-03-08 00:08:42]

The CQ bit was checked by kylechar@chromium.org

[commit-bot: I haz the power, 2017-03-08 00:09:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 00:15:12]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488931722636190,
"parent_rev": "83b6b6817f86ccac039d81bc73d6c5b09b17c064", "commit_rev":
"1df13216e40fed4c8fa2531fc4c764eca1aae018"}

[commit-bot: I haz the power, 2017-03-08 00:15:59]

Description was changed from

==========
Finish OSMesa support for Ozone X11.

Modify the GLOzone implementation for Ozone X11 OSMesa to use
GLSurfaceOSMesaX11. This copies the bitmap that OSMesa generated to the
XWindow so it's visible.

BUG=698780
==========

to

==========
Finish OSMesa support for Ozone X11.

Modify the GLOzone implementation for Ozone X11 OSMesa to use
GLSurfaceOSMesaX11. This copies the bitmap that OSMesa generated to the
XWindow so it's visible.

BUG=698780

Review-Url: https://codereview.chromium.org/2730993002
Cr-Commit-Position: refs/heads/master@{#455306}
Committed:
https://chromium.googlesource.com/chromium/src/+/1df13216e40fed4c8fa2531fc4c7...
==========

[commit-bot: I haz the power, 2017-03-08 00:16:01]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1df13216e40fed4c8fa2531fc4c7...

[Ken Rockot(use gerrit already), 2017-03-09 05:58:21]

A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/2742713002/ by rockot@chromium.org.

The reason for reverting is: Sorry, speculatively reverting based on persistent
ozone builder flake. Started with this CL as best as I can tell.

Appears to be a sync command buffer IPC hang on shutdown, affecting only tests
which force single-process mode. Possibly a deadlock caused by ... something in
the OSMesa/X11?

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux...

.