Make rootEditableElementOrTreeScopeRootNodeOf() to take Position instead of VisibleSeleciton

Make rootEditableElementOrTreeScopeRootNodeOf() to take Position instead of VisibleSelection

This patch makes |rootEditableElementOrTreeScopeRootNodeOf() | to take
|Position| instead of |VisibleSelection| as preparation of reduce usage of
|VisibleSelection| for improving code health.

This patch also replaces deprecated version of |computeVisibleSelection()|
in |InputMethodController::getSelectionOffsets()| since it is called in
after |computeVisibleSelectionDeprecated()|.

BUG=657237
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2742703002
Cr-Commit-Position: refs/heads/master@{#455711}
Committed: https://chromium.googlesource.com/chromium/src/+/b4fed54d2920ee4662f7e77049ff500f24fad905

[yosin_UTC9, 2017-03-09 06:00:16]

Patchset #1 (id:1) has been deleted

[yosin_UTC9, 2017-03-09 06:01:03]

Description was changed from

==========
2017-03-09T14:57:43

2017-03-09T14:57:17

BUG=
==========

to

==========
2017-03-09T14:57:43

2017-03-09T14:57:17

BUG=657237
==========

[yosin_UTC9, 2017-03-09 06:01:09]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 06:01:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-03-09 06:59:24]

Description was changed from

==========
2017-03-09T14:57:43

2017-03-09T14:57:17

BUG=657237
==========

to

==========
Make rootEditableElementOrTreeScopeRootNodeOf() to take Position instead of
VisibleSelection

This patch makes |rootEditableElementOrTreeScopeRootNodeOf() | to take
|Position| instead of |VisibleSelection| as preparation of reduce usage of
|VisibleSelection| for improving code health.

This patch also replaces deprecated version of |computeVisibleSelection()|
in |InputMethodController::getSelectionOffsets()| since it is called in
after |computeVisibleSelectionDeprecated()|.

BUG=657237
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-03-09 07:00:13]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-03-09 07:00:13]

PTAL

https://codereview.chromium.org/2742703002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/InputMethodController.cpp (right):

https://codereview.chromium.org/2742703002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/InputMethodController.cpp:778:
frame().selection().computeVisibleSelectionInDOMTree().base());
L774 calls computeVisibleSelectionInDOMTreeDeprecated()

[commit-bot: I haz the power, 2017-03-09 07:23:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 07:23:55]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yoichio, 2017-03-09 08:55:23]

lgtm

[yosin_UTC9, 2017-03-09 09:04:30]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-03-09 09:04:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 11:16:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489050270774060,
"parent_rev": "ca3ea42526a3541f6b54b0fef9104a28471438b9", "commit_rev":
"b4fed54d2920ee4662f7e77049ff500f24fad905"}

[commit-bot: I haz the power, 2017-03-09 11:17:15]

Description was changed from

==========
Make rootEditableElementOrTreeScopeRootNodeOf() to take Position instead of
VisibleSelection

This patch makes |rootEditableElementOrTreeScopeRootNodeOf() | to take
|Position| instead of |VisibleSelection| as preparation of reduce usage of
|VisibleSelection| for improving code health.

This patch also replaces deprecated version of |computeVisibleSelection()|
in |InputMethodController::getSelectionOffsets()| since it is called in
after |computeVisibleSelectionDeprecated()|.

BUG=657237
TEST=n/a; no behavior changes
==========

to

==========
Make rootEditableElementOrTreeScopeRootNodeOf() to take Position instead of
VisibleSelection

This patch makes |rootEditableElementOrTreeScopeRootNodeOf() | to take
|Position| instead of |VisibleSelection| as preparation of reduce usage of
|VisibleSelection| for improving code health.

This patch also replaces deprecated version of |computeVisibleSelection()|
in |InputMethodController::getSelectionOffsets()| since it is called in
after |computeVisibleSelectionDeprecated()|.

BUG=657237
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2742703002
Cr-Commit-Position: refs/heads/master@{#455711}
Committed:
https://chromium.googlesource.com/chromium/src/+/b4fed54d2920ee4662f7e77049ff...
==========

[commit-bot: I haz the power, 2017-03-09 11:17:16]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b4fed54d2920ee4662f7e77049ff...