Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.cpp

Issue 2742703002: Make rootEditableElementOrTreeScopeRootNodeOf() to take Position instead of VisibleSeleciton (Closed)
Patch Set: 2017-03-09T14:58:18 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/FrameSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.cpp b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
index 03148bbd7cb508b7361178b61f323504a17cf2ac..80820464e7b424a064e76b8b14430f9bdd67addf 100644
--- a/third_party/WebKit/Source/core/editing/FrameSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
@@ -141,12 +141,12 @@ Element* FrameSelection::rootEditableElementOrDocumentElement() const {
// TODO(yosin): We should move |rootEditableElementOrTreeScopeRootNodeOf()| to
// "EditingUtilities.cpp"
ContainerNode* rootEditableElementOrTreeScopeRootNodeOf(
- const VisibleSelection& visibleSelection) {
- Element* selectionRoot = visibleSelection.rootEditableElement();
+ const Position& position) {
+ Element* selectionRoot = rootEditableElementOf(position);
if (selectionRoot)
return selectionRoot;
- Node* const node = visibleSelection.base().computeContainerNode();
+ Node* const node = position.computeContainerNode();
return node ? &node->treeScope().rootNode() : 0;
}

Powered by Google App Engine
This is Rietveld 408576698