third_party/WebKit/Source/core/page/scrolling/RootScrollerController.cpp - Issue 2742673002: Remove FrameHost::globalRootScrollerController()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/RootScrollerController.cpp

Issue 2742673002: Remove FrameHost::globalRootScrollerController() (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/scrolling/RootScrollerController.cpp

diff --git a/third_party/WebKit/Source/core/page/scrolling/RootScrollerController.cpp b/third_party/WebKit/Source/core/page/scrolling/RootScrollerController.cpp

index 1abf9c82139625a5421e671e24b0c8ed07441b8b..5c086312d890f9b33f5fe43964c128e1ec5add5d 100644

--- a/third_party/WebKit/Source/core/page/scrolling/RootScrollerController.cpp

+++ b/third_party/WebKit/Source/core/page/scrolling/RootScrollerController.cpp

@@ -6,11 +6,11 @@

#include "core/dom/Document.h"

#include "core/dom/Element.h"

-#include "core/frame/FrameHost.h"

#include "core/frame/FrameView.h"

#include "core/layout/LayoutBox.h"

#include "core/layout/api/LayoutViewItem.h"

#include "core/layout/compositing/PaintLayerCompositor.h"

+#include "core/page/Page.h"

#include "core/page/scrolling/RootScrollerUtil.h"

#include "core/page/scrolling/TopDocumentRootScrollerController.h"

#include "core/paint/PaintLayer.h"

@@ -122,8 +122,8 @@ void RootScrollerController::recomputeEffectiveRootScroller() {

CompositingUpdateRebuildTree);

}

- if (FrameHost* frameHost = m_document->frameHost())

- frameHost->globalRootScrollerController().didChangeRootScroller();

+ if (Page* page = m_document->page())

+ page->globalRootScrollerController().didChangeRootScroller();

}

bool RootScrollerController::isValidRootScroller(const Element& element) const {