[Web Payments] Use shippingType to choose the Payment Sheet shipping strings.

[Web Payments] Use shippingType to choose the Payment Sheet shipping strings.

BUG=700499
Review-Url: https://codereview.chromium.org/2742643004
Cr-Commit-Position: refs/heads/master@{#456207}
Committed: https://chromium.googlesource.com/chromium/src/+/fd95cbb906c7144c7e3396296791f6c1e0e5fc58

[anthonyvd, 2017-03-10 20:41:20]

The CQ bit was checked by anthonyvd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 20:41:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[anthonyvd, 2017-03-10 20:42:21]

anthonyvd@chromium.org changed reviewers:
+ mathp@chromium.org

[anthonyvd, 2017-03-10 20:42:22]

Hi mathp@, can you PTAL?

I'll implement this change in the appropriate subsheets when Tommy's refactor of
"list" sheets lands.

Thanks!

[Mathieu, 2017-03-10 20:47:29]

few comments!

https://codereview.chromium.org/2742643004/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/payment_request_views_util.cc (right):

https://codereview.chromium.org/2742643004/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/payment_request_views_util.cc:253: if
(shipping_type == payments::mojom::PaymentShippingType::DELIVERY)
Could we have a switch(shipping_type) with three cases, which would complain if
there is ever a new enum value added?

https://codereview.chromium.org/2742643004/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/payment_request_views_util.h (right):

https://codereview.chromium.org/2742643004/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/payment_request_views_util.h:12: #include
"components/payments/content/payment_request.h"
Do you need this include? 

If you mean to #include "components/payments/content/payment_request.mojom.h", 

you could forward declare?

[anthonyvd, 2017-03-10 20:58:53]

https://codereview.chromium.org/2742643004/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/payment_request_views_util.cc (right):

https://codereview.chromium.org/2742643004/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/payment_request_views_util.cc:253: if
(shipping_type == payments::mojom::PaymentShippingType::DELIVERY)
On 2017/03/10 at 20:47:29, Mathieu Perreault wrote:
> Could we have a switch(shipping_type) with three cases, which would complain
if there is ever a new enum value added?

Good point, I set it up like this when I was confused and thought the value
would be a string (since that's what javascript passes).

Done.

https://codereview.chromium.org/2742643004/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/payment_request_views_util.h (right):

https://codereview.chromium.org/2742643004/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/payment_request_views_util.h:12: #include
"components/payments/content/payment_request.h"
On 2017/03/10 at 20:47:29, Mathieu Perreault wrote:
> Do you need this include? 
> 
> If you mean to #include "components/payments/content/payment_request.mojom.h",

> 
> you could forward declare?

Can't forward declare an enum but I changed this include to the mojom one.

[Mathieu, 2017-03-10 21:00:51]

lgtm, yay for reused strings!

[anthonyvd, 2017-03-10 21:42:36]

The CQ bit was checked by anthonyvd@chromium.org

[commit-bot: I haz the power, 2017-03-10 21:43:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 21:56:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 21:57:01]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[anthonyvd, 2017-03-10 22:04:36]

The CQ bit was checked by anthonyvd@chromium.org

[anthonyvd, 2017-03-10 22:04:36]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org
Link to the patchset: https://codereview.chromium.org/2742643004/#ps40001
(title: "Fix windows compile.")

[commit-bot: I haz the power, 2017-03-10 22:05:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 23:08:28]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489183476166080,
"parent_rev": "4e8a5913db16cc7f60ff3595afbd76c81470a698", "commit_rev":
"fd95cbb906c7144c7e3396296791f6c1e0e5fc58"}

[commit-bot: I haz the power, 2017-03-10 23:09:10]

Description was changed from

==========
[Web Payments] Use shippingType to choose the Payment Sheet shipping strings.

BUG=700499
==========

to

==========
[Web Payments] Use shippingType to choose the Payment Sheet shipping strings.

BUG=700499

Review-Url: https://codereview.chromium.org/2742643004
Cr-Commit-Position: refs/heads/master@{#456207}
Committed:
https://chromium.googlesource.com/chromium/src/+/fd95cbb906c7144c7e3396296791...
==========

[commit-bot: I haz the power, 2017-03-10 23:09:12]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/fd95cbb906c7144c7e3396296791...