Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: chrome/browser/ui/views/payments/payment_sheet_view_controller.cc

Issue 2742643004: [Web Payments] Use shippingType to choose the Payment Sheet shipping strings. (Closed)
Patch Set: Fix windows compile. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
diff --git a/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc b/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
index e2070ab90a0fbd693eb852fd80f7a9e29cefe95b..a5ae9409a6046773a846e76ef0b1dbfadb39760d 100644
--- a/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
+++ b/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
@@ -414,7 +414,7 @@ PaymentSheetViewController::CreateShippingSectionContent() {
std::unique_ptr<views::Button> PaymentSheetViewController::CreateShippingRow() {
std::unique_ptr<views::Button> section = CreatePaymentSheetRow(
this,
- l10n_util::GetStringUTF16(IDS_PAYMENT_REQUEST_SHIPPING_SECTION_NAME),
+ GetShippingAddressSectionString(request()->options()->shipping_type),
CreateShippingSectionContent(), std::unique_ptr<views::View>(nullptr),
widest_name_column_view_width_);
section->set_tag(
@@ -528,10 +528,8 @@ PaymentSheetViewController::CreateShippingOptionContent() {
std::unique_ptr<views::Button>
PaymentSheetViewController::CreateShippingOptionRow() {
- // TODO(anthonyvd): Use the correct IDS_PAYMENTS_*_OPTION_LABEL string based
- // on the data passed by the website.
std::unique_ptr<views::Button> section = CreatePaymentSheetRow(
- this, l10n_util::GetStringUTF16(IDS_PAYMENTS_SHIPPING_OPTION_LABEL),
+ this, GetShippingOptionSectionString(request()->options()->shipping_type),
CreateShippingOptionContent(), std::unique_ptr<views::View>(nullptr),
widest_name_column_view_width_);
section->set_tag(static_cast<int>(
« no previous file with comments | « chrome/browser/ui/views/payments/payment_request_views_util.cc ('k') | components/payments/content/payment_request.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698