Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 2742513003: Revert of Remove a lot of pre-MD code from NetworkStateListDetailedView (Closed)

Created:
3 years, 9 months ago by xhwang
Modified:
3 years, 9 months ago
Reviewers:
tdanderson, Evan Stade
CC:
chromium-reviews, kalyank, stevenjb+watch_chromium.org, sadrul, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove a lot of pre-MD code from NetworkStateListDetailedView (patchset #7 id:110001 of https://codereview.chromium.org/2723863004/ ) Reason for revert: This is breaking Google Chrome ChromeOS bot: http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/30458 Original issue's description: > Remove a lot of pre-MD code from NetworkStateListDetailedView > > BUG=686251 > > Review-Url: https://codereview.chromium.org/2723863004 > Cr-Commit-Position: refs/heads/master@{#455552} > Committed: https://chromium.googlesource.com/chromium/src/+/1e65c53ffdbcab7f2d25f064a3a7540166101e54 TBR=tdanderson@chromium.org,estade@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=686251 Review-Url: https://codereview.chromium.org/2742513003 Cr-Commit-Position: refs/heads/master@{#455556} Committed: https://chromium.googlesource.com/chromium/src/+/9d6d1bab117b08c8aa134f09f20d70c7d1eb3d35

Patch Set 1 #

Messages

Total messages: 6 (3 generated)
xhwang
Created Revert of Remove a lot of pre-MD code from NetworkStateListDetailedView
3 years, 9 months ago (2017-03-08 22:24:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742513003/1
3 years, 9 months ago (2017-03-08 22:24:36 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 22:26:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9d6d1bab117b08c8aa134f09f20d...

Powered by Google App Engine
This is Rietveld 408576698