Remove a lot of pre-MD code from NetworkStateListDetailedView

Remove a lot of pre-MD code from NetworkStateListDetailedView

BUG=686251
Review-Url: https://codereview.chromium.org/2723863004
Cr-Commit-Position: refs/heads/master@{#455552}
Committed: https://chromium.googlesource.com/chromium/src/+/1e65c53ffdbcab7f2d25f064a3a7540166101e54

[Evan Stade, 2017-03-02 03:09:51]

estade@chromium.org changed reviewers:
+ tdanderson@chromium.org

[tdanderson, 2017-03-02 21:42:19]

The diff here is quite large, and I am wary of diving into a review of this
without a CL description containing some more details on the changes you are
making. For instance, in addition to removing pre-MD code from
NetworkStateListDetailedView I see that you are also folding NetworkListViewMd
into NetworkListView; are there any non-mechanical changes you made as part of
that I should be paying specific attention to?

[Evan Stade, 2017-03-03 00:22:19]

On 2017/03/02 21:42:19, tdanderson wrote:
> The diff here is quite large, and I am wary of diving into a review of this
> without a CL description containing some more details on the changes you are
> making. For instance, in addition to removing pre-MD code from
> NetworkStateListDetailedView I see that you are also folding NetworkListViewMd
> into NetworkListView; are there any non-mechanical changes you made as part of
> that I should be paying specific attention to?

no, it's totally mechanical. I simply deleted the non-md one and renamed the md
one.

[tdanderson, 2017-03-07 22:30:41]

LG but I'd like to take another glance over it after a rebase; looks like you're
adding the progress bar in NetworkStateListDetailedView::UpdateHeaderButtons()
in this CL but that was already added.

[Evan Stade, 2017-03-07 23:39:25]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 23:40:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 00:19:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 00:19:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2017-03-08 19:51:17]

this cl has now conflicted twice with jamescook file moves and once with a
varkha patch. It would be nice to land before I'm gone for a week and more
conflicts crop up.

I held off on changing the filename of network_list_md.cc/h so that the diff is
cleaner.

[Evan Stade, 2017-03-08 19:51:27]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 19:52:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tdanderson, 2017-03-08 20:49:41]

LGTM

[Evan Stade, 2017-03-08 21:04:17]

The CQ bit was unchecked by estade@chromium.org

[Evan Stade, 2017-03-08 21:04:23]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2017-03-08 21:05:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 22:00:18]

CQ is committing da patch.

Bot data: {"patchset_id": 110001, "attempt_start_ts": 1489007063629060,
"parent_rev": "e23907eaba82f5595b74fb0094968481d6e00514", "commit_rev":
"1e65c53ffdbcab7f2d25f064a3a7540166101e54"}

[commit-bot: I haz the power, 2017-03-08 22:01:01]

Description was changed from

==========
Remove a lot of pre-MD code from NetworkStateListDetailedView

BUG=686251
==========

to

==========
Remove a lot of pre-MD code from NetworkStateListDetailedView

BUG=686251

Review-Url: https://codereview.chromium.org/2723863004
Cr-Commit-Position: refs/heads/master@{#455552}
Committed:
https://chromium.googlesource.com/chromium/src/+/1e65c53ffdbcab7f2d25f064a3a7...
==========

[commit-bot: I haz the power, 2017-03-08 22:01:02]

Committed patchset #7 (id:110001) as
https://chromium.googlesource.com/chromium/src/+/1e65c53ffdbcab7f2d25f064a3a7...

[xhwang, 2017-03-08 22:17:27]

xhwang@chromium.org changed reviewers:
+ xhwang@chromium.org

[xhwang, 2017-03-08 22:17:27]

This is breaking Google Chrome ChromeOS bot:

http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Chrome...

estade: Will you take a look? Or we can revert first.

[xhwang, 2017-03-08 22:24:06]

A revert of this CL (patchset #7 id:110001) has been created in
https://codereview.chromium.org/2742513003/ by xhwang@chromium.org.

The reason for reverting is: This is breaking Google Chrome ChromeOS bot:

http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Chrome....