Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Issue 2742503002: [DevTools] Adjust popover position so accomodate for arrow. (Closed)

Created:
3 years, 9 months ago by dgozman
Modified:
3 years, 9 months ago
Reviewers:
alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Adjust popover position so accomodate for arrow. When there is enough space we can move popover so that arrow points to the middle of anchor box (as opposite to the side). BUG=699489 Review-Url: https://codereview.chromium.org/2742503002 Cr-Commit-Position: refs/heads/master@{#455622} Committed: https://chromium.googlesource.com/chromium/src/+/c2d78373f7f7b3e71c3f08707d7d0a27c082de1d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js View 2 chunks +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
dgozman
Could you please take a look?
3 years, 9 months ago (2017-03-08 21:34:58 UTC) #2
alph
lgtm
3 years, 9 months ago (2017-03-09 00:07:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742503002/1
3 years, 9 months ago (2017-03-09 00:43:14 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 01:24:21 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c2d78373f7f7b3e71c3f08707d7d...

Powered by Google App Engine
This is Rietveld 408576698