Formalizing the hacks letting the angular analyzer plugin run for now.

Formalizing the hacks letting the angular analyzer plugin run for now.

Mostly just making private methods public. But also add in some hooks
(via streams and callbacks) that allow the angular analyzer to wrap
analysis drivers in new angular drivers.

This code will likely all be reverted at some point when a much much
better plugin API is available.

BUG=
R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/ebab20824a201dc061e80273c6e2be86e7af1efc

[mfairhurst, 2017-03-13 20:24:39]

mfairhurst@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2017-03-13 21:00:22]

lgtm

https://codereview.chromium.org/2742343006/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/2742343006/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/analysis_server.dart:386: // "new
NotificationManager(channel, resourceProvider)"
You can delete the TODO comment now.

https://codereview.chromium.org/2742343006/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/analysis_server.dart:1554:
_onFileAddedController.add(file);
Should this be `_onFileChangedController`?

[mfairhurst, 2017-03-14 19:09:30]

Description was changed from

==========
Formalizing the hacks letting the angular analyzer plugin run for now.

Mostly just making private methods public. But also add in some hooks
(via streams and callbacks) that allow the angular analyzer to wrap
analysis drivers in new angular drivers.

This code will likely all be reverted at some point when a much much
better plugin API is available.

BUG=
==========

to

==========
Formalizing the hacks letting the angular analyzer plugin run for now.

Mostly just making private methods public. But also add in some hooks
(via streams and callbacks) that allow the angular analyzer to wrap
analysis drivers in new angular drivers.

This code will likely all be reverted at some point when a much much
better plugin API is available.

BUG=
R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ebab20824a201dc061e80273c6e2be86e7af1efc
==========

[mfairhurst, 2017-03-14 19:09:31]

Committed patchset #3 (id:40001) manually as
ebab20824a201dc061e80273c6e2be86e7af1efc (presubmit successful).