Formalizing the hacks letting the angular analyzer plugin run for now.

pkg/analysis_server/lib/src/analysis_server.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analysis.server;
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:core';
 import 'dart:io' as io;
@@ skipping 318 matching lines @@
    * The package resolver provider used to override the way package URI's are
    * resolved in some contexts.
    */
   ResolverProvider packageResolverProvider;
 
   nd.PerformanceLog _analysisPerformanceLogger;
   ByteStore byteStore;
   nd.AnalysisDriverScheduler analysisDriverScheduler;
 
   /**
+   * This exists as a temporary stopgap for plugins, until the official plugin
+   * API is complete.
+   */
+  StreamController<String> _onFileAddedController;
+
+  /**
+   * This exists as a temporary stopgap for plugins, until the official plugin
+   * API is complete.
+   */
+  StreamController<String> _onFileChangedController;
+
+  /**
    * The set of the files that are currently priority.
    */
   final Set<String> priorityFiles = new Set<String>();
 
   /**
    * The DiagnosticServer for this AnalysisServer. If available, it can be used
    * to start an http diagnostics server or return the port for an existing
    * server.
    */
   DiagnosticServer diagnosticServer;
@@ skipping 15 matching lines @@
       this.serverPlugin,
       this.options,
       this.sdkManager,
       this.instrumentationService,
       {this.diagnosticServer,
       ResolverProvider fileResolverProvider: null,
       ResolverProvider packageResolverProvider: null,
       bool useSingleContextManager: false,
       this.rethrowExceptions: true})
       // TODO(brianwilkerson) Initialize notificationManager to
       // "new NotificationManager(channel, resourceProvider)"

[Brian Wilkerson, 2017/03/13 21:00:22]

You can delete the TODO comment now.

-      : notificationManager = null {
+      : notificationManager =
+            new NotificationManager(channel, resourceProvider) {
     _performance = performanceDuringStartup;
     defaultContextOptions.incremental = true;
     defaultContextOptions.incrementalApi =
         options.enableIncrementalResolutionApi;
     defaultContextOptions.incrementalValidation =
         options.enableIncrementalResolutionValidation;
     defaultContextOptions.finerGrainedInvalidation =
         options.finerGrainedInvalidation;
     defaultContextOptions.generateImplicitErrors = false;
     operationQueue = new ServerOperationQueue();
@@ skipping 32 matching lines @@
           options.enableNewAnalysisDriver);
     }
     this.fileResolverProvider = fileResolverProvider;
     this.packageResolverProvider = packageResolverProvider;
     ServerContextManagerCallbacks contextManagerCallbacks =
         new ServerContextManagerCallbacks(this, resourceProvider);
     contextManager.callbacks = contextManagerCallbacks;
     AnalysisEngine.instance.logger = new AnalysisLogger(this);
     _onAnalysisStartedController = new StreamController.broadcast();
     _onFileAnalyzedController = new StreamController.broadcast();
+    // temporary plugin support:
+    _onFileAddedController = new StreamController.broadcast();
+    // temporary plugin support:
+    _onFileChangedController = new StreamController.broadcast();
     _onPriorityChangeController =
         new StreamController<PriorityChangeEvent>.broadcast();
     running = true;
     onAnalysisStarted.first.then((_) {
       onAnalysisComplete.then((_) {
         performanceAfterStartup = new ServerPerformance();
         _performance = performanceAfterStartup;
       });
     });
     _setupIndexInvalidation();
@@ skipping 74 matching lines @@
    */
   Stream<ContextsChangedEvent> get onContextsChanged =>
       _onContextsChangedController.stream;
 
   /**
    * The stream that is notified when a single file has been analyzed.
    */
   Stream get onFileAnalyzed => _onFileAnalyzedController.stream;
 
   /**
+   * The stream that is notified when a single file has been added. This exists
+   * as a temporary stopgap for plugins, until the official plugin API is
+   * complete.
+   */
+  Stream get onFileAdded => _onFileAddedController.stream;
+
+  /**
+   * The stream that is notified when a single file has been changed. This
+   * exists as a temporary stopgap for plugins, until the official plugin API is
+   * complete.
+   */
+  Stream get onFileChanged => _onFileChangedController.stream;
+
+  /**
    * The stream that is notified when priority sources change.
    */
   Stream<PriorityChangeEvent> get onPriorityChange =>
       _onPriorityChangeController.stream;
 
   /**
    * The [Future] that completes when the next operation is performed.
    */
   Future get test_onOperationPerformed {
     if (_test_onOperationPerformedCompleter == null) {
@@ skipping 980 matching lines @@
           // Protocol parsing should have ensured that we never get here.
           throw new AnalysisException('Illegal change type');
         }
 
         fileContentOverlay[file] = newContents;
 
         driverMap.values.forEach((driver) {
           driver.changeFile(file);
         });
 
+        // temporary plugin support:
+        _onFileAddedController.add(file);

[Brian Wilkerson, 2017/03/13 21:00:22]

Should this be `_onFileChangedController`?

+
         // If the file did not exist, and is "overlay only", it still should be
         // analyzed. Add it to driver to which it should have been added.
         contextManager.getDriverFor(file)?.addFile(file);
 
         // TODO(scheglov) implement other cases
       });
       return;
     }
     changes.forEach((file, change) {
       ContextSourcePair contextSource = getContextSourcePair(file);
@@ skipping 449 matching lines @@
   }
 
   @override
   void applyChangesToContext(Folder contextFolder, ChangeSet changeSet) {
     if (analysisServer.options.enableNewAnalysisDriver) {
       nd.AnalysisDriver analysisDriver =
           analysisServer.driverMap[contextFolder];
       if (analysisDriver != null) {
         changeSet.addedSources.forEach((source) {
           analysisDriver.addFile(source.fullName);
+          // temporary plugin support:
+          analysisServer._onFileAddedController.add(source.fullName);
         });
         changeSet.changedSources.forEach((source) {
           analysisDriver.changeFile(source.fullName);
+          // temporary plugin support:
+          analysisServer._onFileChangedController.add(source.fullName);
         });
         changeSet.removedSources.forEach((source) {
           analysisDriver.removeFile(source.fullName);
         });
       }
     } else {
       AnalysisContext context = analysisServer.folderMap[contextFolder];
       if (context != null) {
         context.applyChanges(changeSet);
         analysisServer.schedulePerformAnalysisOperation(context);
@@ skipping 255 matching lines @@
   /**
    * The [PerformanceTag] for time spent in server request handlers.
    */
   static PerformanceTag serverRequests = new PerformanceTag('serverRequests');
 
   /**
    * The [PerformanceTag] for time spent in split store microtasks.
    */
   static PerformanceTag splitStore = new PerformanceTag('splitStore');
 }