Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2518)

Unified Diff: pkg/analysis_server/lib/src/server/driver.dart

Issue 2742343006: Formalizing the hacks letting the angular analyzer plugin run for now. (Closed)
Patch Set: Rename variable not method Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/context_manager.dart ('k') | pkg/analysis_server/lib/starter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/server/driver.dart
diff --git a/pkg/analysis_server/lib/src/server/driver.dart b/pkg/analysis_server/lib/src/server/driver.dart
index 183b6ffc5a394dfca18fb794569ffae00c7a1155..a96f054495fbc03fa5fabea87ba9b89435588d0e 100644
--- a/pkg/analysis_server/lib/src/server/driver.dart
+++ b/pkg/analysis_server/lib/src/server/driver.dart
@@ -348,13 +348,17 @@ class Driver implements ServerStarter {
/**
* Use the given command-line [arguments] to start this server.
+ *
+ * At least temporarily returns AnalysisServer so that consumers of the
+ * starter API can then use the server, this is done as a stopgap for the
+ * angular plugin until the official plugin API is finished.
*/
- void start(List<String> arguments) {
+ AnalysisServer start(List<String> arguments) {
CommandLineParser parser = _createArgParser();
ArgResults results = parser.parse(arguments, <String, String>{});
if (results[HELP_OPTION]) {
_printUsage(parser.parser);
- return;
+ return null;
}
// TODO (danrubel) Remove this workaround
@@ -375,7 +379,7 @@ class Driver implements ServerStarter {
print('');
_printUsage(parser.parser);
exitCode = 1;
- return;
+ return null;
}
}
@@ -484,6 +488,8 @@ class Driver implements ServerStarter {
},
print:
results[INTERNAL_PRINT_TO_CONSOLE] ? null : httpServer.recordPrint);
+
+ return socketServer.analysisServer;
}
/**
« no previous file with comments | « pkg/analysis_server/lib/src/context_manager.dart ('k') | pkg/analysis_server/lib/starter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698