Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2742303002: [Merge to M-58]Add bottom border to StyledLabel. (Closed)

Created:
3 years, 9 months ago by dvadym
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Merge to M-58]Add bottom border to StyledLabel. On CL https://codereview.chromium.org/2072513003 it was changed calculation of height of StyledLabel, so the |total_height| is equal to the bottom point of lowest sublabel. This doesn't take into consideration a bottom border. Screenshots are on the bug. This CL fixes this. BUG=697034 Review-Url: https://codereview.chromium.org/2722503005 Cr-Commit-Position: refs/heads/master@{#455495} (cherry picked from commit 2581d91a5a2adfdae460bd25a43b44cac6f80ded) Review-Url: https://codereview.chromium.org/2742303002 . Cr-Commit-Position: refs/branch-heads/3029@{#144} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/be0be00087150bd7c26414bcd3898c83e241fd7c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M ui/views/controls/styled_label.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M ui/views/controls/styled_label_unittest.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dvadym
3 years, 9 months ago (2017-03-13 10:55:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
be0be00087150bd7c26414bcd3898c83e241fd7c.

Powered by Google App Engine
This is Rietveld 408576698