Fix StyledLabel so it doesn't clip the bottom of Hindi text.

Fix StyledLabel so it doesn't clip the bottom of Hindi text.

A label can be taller than the calculated line height, so set the height
according to the bottom of the lowest label (link) as we iterate through
StyledLabel sub-views.

Also, somewhat tangentially, reduce the amount of nesting
in BubbleSyncPromoView by making it a StyledLabel rather
than a view containing a single StyledLabel.

BUG=618978
Committed: https://crrev.com/85882eb4e66d924e623be4246894d96d7344fce8
Cr-Commit-Position: refs/heads/master@{#400833}

[Evan Stade, 2016-06-16 18:02:39]

Description was changed from

==========
Fix StyledLabel so it doesn't clip the bottom of Hindi text.

A label can be taller than the calculated line height, so set the height
according to the bottom of the lowest label (link) as we iterate through
StyledLabel sub-views.

BUG=618978
==========

to

==========
Fix StyledLabel so it doesn't clip the bottom of Hindi text.

A label can be taller than the calculated line height, so set the height
according to the bottom of the lowest label (link) as we iterate through
StyledLabel sub-views.

Also, somewhat tangentially, reduce the amount of nesting 
in BubbleSyncPromoView by making it a StyledLabel rather 
than a view containing a single StyledLabel.

BUG=618978
==========

[Evan Stade, 2016-06-16 18:02:40]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[Evan Stade, 2016-06-16 18:02:45]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-16 18:03:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2072513003/1

[commit-bot: I haz the power, 2016-06-16 18:56:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-16 18:56:32]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2016-06-20 16:38:32]

ping

[sky, 2016-06-20 19:26:06]

If the label ends up being taller than won't labels by layed out on top of each
other?

https://codereview.chromium.org/2072513003/diff/1/chrome/browser/ui/views/syn...
File chrome/browser/ui/views/sync/bubble_sync_promo_view.cc (right):

https://codereview.chromium.org/2072513003/diff/1/chrome/browser/ui/views/syn...
chrome/browser/ui/views/sync/bubble_sync_promo_view.cc:58: const char*
BubbleSyncPromoView::GetClassName() const {
nit: move to match new position.

[Evan Stade, 2016-06-20 20:31:24]

On 2016/06/20 19:26:06, sky wrote:
> If the label ends up being taller than won't labels by layed out on top of
each
> other?

I assume you mean taller than the line height. I think the answer is yes, but
that's already the case. As you can see in the screenshots on the bug, the focus
border seems to leave a lot of vertical room above and below the text for Hindi
text. I don't know much about Hindi but otherwise the line spacing in the
screenshots looks ok to me, so I assume it's not a problem that there is some
vertical overlap.

https://codereview.chromium.org/2072513003/diff/1/chrome/browser/ui/views/syn...
File chrome/browser/ui/views/sync/bubble_sync_promo_view.cc (right):

https://codereview.chromium.org/2072513003/diff/1/chrome/browser/ui/views/syn...
chrome/browser/ui/views/sync/bubble_sync_promo_view.cc:58: const char*
BubbleSyncPromoView::GetClassName() const {
On 2016/06/20 19:26:06, sky wrote:
> nit: move to match new position.

Done.

[sky, 2016-06-20 21:52:44]

Ok, LGTM

[Evan Stade, 2016-06-20 21:54:07]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-06-20 21:54:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2072513003/20001

[commit-bot: I haz the power, 2016-06-20 23:38:48]

Description was changed from

==========
Fix StyledLabel so it doesn't clip the bottom of Hindi text.

A label can be taller than the calculated line height, so set the height
according to the bottom of the lowest label (link) as we iterate through
StyledLabel sub-views.

Also, somewhat tangentially, reduce the amount of nesting 
in BubbleSyncPromoView by making it a StyledLabel rather 
than a view containing a single StyledLabel.

BUG=618978
==========

to

==========
Fix StyledLabel so it doesn't clip the bottom of Hindi text.

A label can be taller than the calculated line height, so set the height
according to the bottom of the lowest label (link) as we iterate through
StyledLabel sub-views.

Also, somewhat tangentially, reduce the amount of nesting 
in BubbleSyncPromoView by making it a StyledLabel rather 
than a view containing a single StyledLabel.

BUG=618978
==========

[commit-bot: I haz the power, 2016-06-20 23:38:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-20 23:40:57]

Description was changed from

==========
Fix StyledLabel so it doesn't clip the bottom of Hindi text.

A label can be taller than the calculated line height, so set the height
according to the bottom of the lowest label (link) as we iterate through
StyledLabel sub-views.

Also, somewhat tangentially, reduce the amount of nesting 
in BubbleSyncPromoView by making it a StyledLabel rather 
than a view containing a single StyledLabel.

BUG=618978
==========

to

==========
Fix StyledLabel so it doesn't clip the bottom of Hindi text.

A label can be taller than the calculated line height, so set the height
according to the bottom of the lowest label (link) as we iterate through
StyledLabel sub-views.

Also, somewhat tangentially, reduce the amount of nesting
in BubbleSyncPromoView by making it a StyledLabel rather
than a view containing a single StyledLabel.

BUG=618978

Committed: https://crrev.com/85882eb4e66d924e623be4246894d96d7344fce8
Cr-Commit-Position: refs/heads/master@{#400833}
==========

[commit-bot: I haz the power, 2016-06-20 23:40:59]

Patchset 2 (id:??) landed as
https://crrev.com/85882eb4e66d924e623be4246894d96d7344fce8
Cr-Commit-Position: refs/heads/master@{#400833}