Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5776)

Unified Diff: chrome/browser/resources/feedback/js/feedback.js

Issue 2742103002: Prevent adding an empty email option in the feedback app in guest mode (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/feedback/js/feedback.js
diff --git a/chrome/browser/resources/feedback/js/feedback.js b/chrome/browser/resources/feedback/js/feedback.js
index 6d8b39c7f939812d2915bcbe0adf9008dfec7df0..cb51b9629910f70da86451009b12e0717b8dffd6 100644
--- a/chrome/browser/resources/feedback/js/feedback.js
+++ b/chrome/browser/resources/feedback/js/feedback.js
@@ -344,6 +344,9 @@ function initialize() {
});
chrome.feedbackPrivate.getUserEmail(function(email) {
+ // Never add an empty option.
+ if (!email)
+ return;
var optionElement = document.createElement('option');
optionElement.value = email;
optionElement.text = email;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698