Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2742003002: Provide instructions if -o or -r is used on public bisect-builds.py (Closed)

Created:
3 years, 9 months ago by elawrence
Modified:
3 years, 8 months ago
Reviewers:
prasadv, Michael Moss
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Provide instructions if -o or -r is used on public bisect-builds.py If the user attempts to use the -o or -r options in the public bisect script, they will fail as unknown options. Instead, we should help the user get the correct version of the script by pointing to the page explaining how to configure their environment. Review-Url: https://codereview.chromium.org/2742003002 Cr-Commit-Position: refs/heads/master@{#464743} Committed: https://chromium.googlesource.com/chromium/src/+/446bcc3d1881a89471235aff30d25c38b2b3547f

Patch Set 1 : Add more help #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M tools/bisect-builds.py View 1 2 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
elawrence
Please take a look? This is a tiny change to help Googlers find the internal ...
3 years, 9 months ago (2017-03-10 16:26:08 UTC) #2
elawrence
PTAL?
3 years, 8 months ago (2017-03-31 21:47:18 UTC) #4
Michael Moss
lgtm
3 years, 8 months ago (2017-03-31 21:49:56 UTC) #5
elawrence
robertocn@chromium.org: PTAL? Sorry if you're not an appropriate reviewer; I've been fumbling through the history ...
3 years, 8 months ago (2017-03-31 21:50:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742003002/20001
3 years, 8 months ago (2017-04-03 14:53:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/400950)
3 years, 8 months ago (2017-04-03 15:04:24 UTC) #11
elawrence
Trying the third of three owners. PTAL?
3 years, 8 months ago (2017-04-14 16:43:58 UTC) #13
prasadv
lgtm
3 years, 8 months ago (2017-04-14 16:53:35 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742003002/40001
3 years, 8 months ago (2017-04-14 17:09:30 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 17:19:48 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/446bcc3d1881a89471235aff30d2...

Powered by Google App Engine
This is Rietveld 408576698