Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: tools/bisect-builds.py

Issue 2742003002: Provide instructions if -o or -r is used on public bisect-builds.py (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bisect-builds.py
diff --git a/tools/bisect-builds.py b/tools/bisect-builds.py
index 442f399253d59c514d15445cba424dc8332228ee..2586814f03221cef5f25ca59f29f9cf9706b64bd 100755
--- a/tools/bisect-builds.py
+++ b/tools/bisect-builds.py
@@ -1001,6 +1001,11 @@ def PrintChangeLog(min_chromium_rev, max_chromium_rev):
print (' ' + CHANGELOG_URL % (GetGitHashFromSVNRevision(min_chromium_rev),
GetGitHashFromSVNRevision(max_chromium_rev)))
+def error_internal_option(option, opt, value, parser):
+ raise optparse.OptionValueError(
+ 'The -o and -r options are only\navailable in the internal version of '
+ 'this script. Google\nemployees should visit http://go/bisect-builds '
+ 'for\nconfiguration instructions.')
def main():
usage = ('%prog [options] [-- chromium-options]\n'
@@ -1086,6 +1091,8 @@ def main():
default=False,
help='Test the first and last revisions in the range ' +
'before proceeding with the bisect.')
+ parser.add_option("-r", action="callback", callback=error_internal_option)
+ parser.add_option("-o", action="callback", callback=error_internal_option)
(opts, args) = parser.parse_args()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698