Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 2741883004: Remove MemoryCoordinatorProxy::SetCurrentMemoryStateForTesting (Closed)

Created:
3 years, 9 months ago by bashi
Modified:
3 years, 9 months ago
Reviewers:
haraken, sky, dcheng
CC:
chromium-reviews, jam, darin-cc_chromium.org, gavinp+memory_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove MemoryCoordinatorProxy::SetCurrentMemoryStateForTesting TabLoaderTest is the only user of SetCurrentMemoryStateForTesting() and we can replace it with MemoryCoordinatorClientRegistry::Notify(). Remove it to simplify memory coordinator interface. BUG=696844 Review-Url: https://codereview.chromium.org/2741883004 Cr-Commit-Position: refs/heads/master@{#456609} Committed: https://chromium.googlesource.com/chromium/src/+/fb7c0ef7062701ffef4b596d04dae8b00057f5ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -44 lines) Patch
M base/memory/memory_coordinator_proxy.h View 2 chunks +0 lines, -4 lines 0 comments Download
M base/memory/memory_coordinator_proxy.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/sessions/tab_loader_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/memory/memory_coordinator_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/memory/memory_coordinator_impl.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/memory/memory_coordinator_impl_unittest.cc View 1 chunk +0 lines, -22 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 23 (14 generated)
bashi
PTAL
3 years, 9 months ago (2017-03-10 09:23:30 UTC) #4
haraken
LGTM
3 years, 9 months ago (2017-03-10 09:26:58 UTC) #5
dcheng
lgtm
3 years, 9 months ago (2017-03-10 09:38:10 UTC) #6
bashi
sky@: friendly ping :)
3 years, 9 months ago (2017-03-13 23:25:46 UTC) #9
sky
LGTM
3 years, 9 months ago (2017-03-13 23:43:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741883004/1
3 years, 9 months ago (2017-03-13 23:44:38 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/227033) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 9 months ago (2017-03-13 23:59:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741883004/1
3 years, 9 months ago (2017-03-14 02:39:55 UTC) #20
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 03:18:27 UTC) #23
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fb7c0ef7062701ffef4b596d04da...

Powered by Google App Engine
This is Rietveld 408576698