Implement base::MemoryCoordinator for ChildMemoryCoordinatorImpl

Implement base::MemoryCoordinator for ChildMemoryCoordinatorImpl

Some components in renderer side want to access memory coordinator from
outside content/ (e.g. v8). Make ChildMemoryCoordinatorImpl be a
subclass of base::MemoryCoordinator so that such components can access
memory coordinator via base::MemoryCoordinatorProxy.

BUG=693430
Review-Url: https://codereview.chromium.org/2739363002
Cr-Commit-Position: refs/heads/master@{#456635}
Committed: https://chromium.googlesource.com/chromium/src/+/05c7a3f7523ff797cf6537109549d4bc513ece64

[bashi, 2017-03-10 09:39:08]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 09:39:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bashi, 2017-03-10 09:41:18]

bashi@chromium.org changed reviewers:
+ haraken@chromium.org

[bashi, 2017-03-10 09:41:19]

PTAL

This is a part of https://codereview.chromium.org/2731913002/ which exposes the
global memory budget to v8.

Also this depends on https://codereview.chromium.org/2741883004/

[haraken, 2017-03-10 09:49:28]

Hmm. Conceptually there should be only one MemoryCoordinator in the browser
side.

So making ChildMemoryCoordinator inherit from MemoryCoordinator sounds a bit
strange to me... ?

[commit-bot: I haz the power, 2017-03-10 10:29:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 10:29:16]

Dry run: This issue passed the CQ dry run.

[bashi, 2017-03-13 00:29:00]

On 2017/03/10 09:49:28, haraken wrote:
> Hmm. Conceptually there should be only one MemoryCoordinator in the browser
> side.
> 
> So making ChildMemoryCoordinator inherit from MemoryCoordinator sounds a bit
> strange to me... ?

Sorry for confusion. base::MemoryCoordinator is the interface to inject a
dependency from content/ to base/ and it is used by MemoryCoordinatorProxy to
provide ways to access process's memory coordinator.

[browser process]

client (e.g. net) --> base::MemoryCoordinatorProxy --> base::MemoryCoordinator
--> MemoryCoordinator

[renderer process]

client (e.g. v8) --> base::MemoryCoordinatorProxy --> base::MemoryCoordinator
--> ChildMemoryCoordinator

Once memory coordinator becomes a service, we wouldn't need this kind of
dependency injection and we should be able to remove base::MemoryCoordinator.

[haraken, 2017-03-13 11:21:21]

On 2017/03/13 00:29:00, bashi wrote:
> On 2017/03/10 09:49:28, haraken wrote:
> > Hmm. Conceptually there should be only one MemoryCoordinator in the browser
> > side.
> > 
> > So making ChildMemoryCoordinator inherit from MemoryCoordinator sounds a bit
> > strange to me... ?
> 
> Sorry for confusion. base::MemoryCoordinator is the interface to inject a
> dependency from content/ to base/ and it is used by MemoryCoordinatorProxy to
> provide ways to access process's memory coordinator.
> 
> [browser process]
> 
> client (e.g. net) --> base::MemoryCoordinatorProxy --> base::MemoryCoordinator
> --> MemoryCoordinator
> 
> [renderer process]
> 
> client (e.g. v8) --> base::MemoryCoordinatorProxy --> base::MemoryCoordinator
> --> ChildMemoryCoordinator
> 
> Once memory coordinator becomes a service, we wouldn't need this kind of
> dependency injection and we should be able to remove base::MemoryCoordinator.

Thanks, makes sense. LGTM.

[bashi, 2017-03-13 23:03:23]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2017-03-13 23:04:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 23:04:11]

This CL has an open dependency (Issue 2741883004 Patch 1). Please resolve the
dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[bashi, 2017-03-14 04:08:20]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2017-03-14 04:08:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 05:33:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 05:33:12]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bashi, 2017-03-14 05:39:41]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2017-03-14 05:39:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 06:13:20]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489469981228750, "parent_rev":
"ecf42a93545affe9be77a837cad4212ad69cd38c", "commit_rev":
"05c7a3f7523ff797cf6537109549d4bc513ece64"}

[commit-bot: I haz the power, 2017-03-14 06:14:19]

Description was changed from

==========
Implement base::MemoryCoordinator for ChildMemoryCoordinatorImpl

Some components in renderer side want to access memory coordinator from
outside content/ (e.g. v8). Make ChildMemoryCoordinatorImpl be a
subclass of base::MemoryCoordinator so that such components can access
memory coordinator via base::MemoryCoordinatorProxy.

BUG=693430
==========

to

==========
Implement base::MemoryCoordinator for ChildMemoryCoordinatorImpl

Some components in renderer side want to access memory coordinator from
outside content/ (e.g. v8). Make ChildMemoryCoordinatorImpl be a
subclass of base::MemoryCoordinator so that such components can access
memory coordinator via base::MemoryCoordinatorProxy.

BUG=693430

Review-Url: https://codereview.chromium.org/2739363002
Cr-Commit-Position: refs/heads/master@{#456635}
Committed:
https://chromium.googlesource.com/chromium/src/+/05c7a3f7523ff797cf6537109549...
==========

[commit-bot: I haz the power, 2017-03-14 06:14:20]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/05c7a3f7523ff797cf6537109549...