Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2741853009: Fix wrong display item type for drag caret (Closed)

Created:
3 years, 9 months ago by Xianzhu
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews, dcheng
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Fix wrong display item type for drag caret The bug seems to have been there since we added DisplayItem::kCaret. This breaks under-invalidation checking itself only. It won't cause any visible issue to release builds, except small performance penalty that the drag caret is always repainted because of no match in the cache with the wrong id. BUG=699480 TBR=wangxianzhu@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2742693002 Cr-Original-Commit-Position: refs/heads/master@{#455778} Review-Url: https://codereview.chromium.org/2741853009 Cr-Commit-Position: refs/branch-heads/3029@{#133} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/db27876368a5427dc351c6cb0a7c5f16718fd3be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/paint/selection/drag-caret.html View 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741853009/1
3 years, 9 months ago (2017-03-12 02:09:32 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-12 02:12:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/db27876368a5427dc351c6cb0a7c...

Powered by Google App Engine
This is Rietveld 408576698