Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Issue 2742693002: Fix wrong display item type for drag caret (Closed)

Created:
3 years, 9 months ago by Xianzhu
Modified:
3 years, 9 months ago
Reviewers:
chrishtr
CC:
blink-reviews, chromium-reviews, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix wrong display item type for drag caret The bug seems to have been there since we added DisplayItem::kCaret. This breaks under-invalidation checking itself only. It won't cause any visible issue to release builds, except small performance penalty that the drag caret is always repainted because of no match in the cache with the wrong id. BUG=699480 Review-Url: https://codereview.chromium.org/2742693002 Cr-Commit-Position: refs/heads/master@{#455778} Committed: https://chromium.googlesource.com/chromium/src/+/b3ea2018ada2075038a527e4b855c9cc3fd24625

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/paint/selection/drag-caret.html View 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Xianzhu
3 years, 9 months ago (2017-03-09 16:59:08 UTC) #7
chrishtr
lgtm
3 years, 9 months ago (2017-03-09 17:12:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742693002/1
3 years, 9 months ago (2017-03-09 17:13:15 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 17:18:48 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b3ea2018ada2075038a527e4b855...

Powered by Google App Engine
This is Rietveld 408576698