Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2740253002: Remove FetchRequest::mutableResourceRequest() where removing is trivial (Closed)

Created:
3 years, 9 months ago by hiroshige
Modified:
3 years, 9 months ago
Reviewers:
Nate Chapin
CC:
chromium-reviews, eae+blinkwatch, apavlov+blink_chromium.org, kinuko+watch, rwlbuis, caseq+blink_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, devtools-reviews_chromium.org, loading-reviews_chromium.org, sof, Yoav Weiss, lushnikov+blink_chromium.org, blink-reviews, darktears, loading-reviews+fetch_chromium.org, Nate Chapin, tyoshino+watch_chromium.org, gavinp+prerender_chromium.org, pfeldman+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove FetchRequest::mutableResourceRequest() where removing is trivial This CL removes FetchRequest::mutableResourceRequest() calls that are used to modify ResourceRequest created just before, i.e. replaces: FetchRequest request(ResourceRequest(foo), bar); request.mutableResourceRequest().baz(); with: ResourceRequest resourceRequest(foo); resourceRequest.baz(); FetchRequest request(resourceRequest, bar); To clarify what kind of modifications to ResourceRequest via mutableResourceRequest() is needed (https://crbug.com/632580#c8). BUG=632580 Review-Url: https://codereview.chromium.org/2740253002 Cr-Commit-Position: refs/heads/master@{#456169} Committed: https://chromium.googlesource.com/chromium/src/+/a51669425d5a771fb9f80663779135c1deffdb00

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -38 lines) Patch
M third_party/WebKit/Source/core/css/CSSFontFaceSrcValue.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSImageSetValue.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSImageValue.cpp View 1 chunk +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 2 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoader.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (12 generated)
hiroshige
PTAL.
3 years, 9 months ago (2017-03-10 20:03:21 UTC) #9
Nate Chapin
lgtm
3 years, 9 months ago (2017-03-10 20:04:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740253002/20001
3 years, 9 months ago (2017-03-10 20:55:33 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 21:36:10 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a51669425d5a771fb9f806637791...

Powered by Google App Engine
This is Rietveld 408576698