Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2741723002: Remove commented out code in GlobalHandles::Node. (Closed)

Created:
3 years, 9 months ago by Yang
Modified:
3 years, 9 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove commented out code in GlobalHandles::Node. This is clearly a case of "nuke later" where later means now. R=mlippautz@chromium.org BUG=v8:6072 Review-Url: https://codereview.chromium.org/2741723002 Cr-Commit-Position: refs/heads/master@{#43713} Committed: https://chromium.googlesource.com/v8/v8/+/a3a244cb8704a7087c542a01ae591c07f18785ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M src/global-handles.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Yang
3 years, 9 months ago (2017-03-09 12:44:54 UTC) #1
Michael Lippautz
lgtm
3 years, 9 months ago (2017-03-09 20:59:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741723002/1
3 years, 9 months ago (2017-03-10 06:29:44 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 07:04:52 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/a3a244cb8704a7087c542a01ae591c07f18...

Powered by Google App Engine
This is Rietveld 408576698