Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Side by Side Diff: src/global-handles.cc

Issue 2741723002: Remove commented out code in GlobalHandles::Node. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/global-handles.h" 5 #include "src/global-handles.h"
6 6
7 #include "src/api.h" 7 #include "src/api.h"
8 #include "src/cancelable-task.h" 8 #include "src/cancelable-task.h"
9 #include "src/objects-inl.h" 9 #include "src/objects-inl.h"
10 #include "src/v8.h" 10 #include "src/v8.h"
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 DCHECK(state() == WEAK); 185 DCHECK(state() == WEAK);
186 set_state(PENDING); 186 set_state(PENDING);
187 } 187 }
188 188
189 // Independent flag accessors. 189 // Independent flag accessors.
190 void MarkIndependent() { 190 void MarkIndependent() {
191 DCHECK(IsInUse()); 191 DCHECK(IsInUse());
192 set_independent(true); 192 set_independent(true);
193 } 193 }
194 194
195 // Callback accessor.
196 // TODO(svenpanne) Re-enable or nuke later.
197 // WeakReferenceCallback callback() { return callback_; }
198
199 // Callback parameter accessors. 195 // Callback parameter accessors.
200 void set_parameter(void* parameter) { 196 void set_parameter(void* parameter) {
201 DCHECK(IsInUse()); 197 DCHECK(IsInUse());
202 parameter_or_next_free_.parameter = parameter; 198 parameter_or_next_free_.parameter = parameter;
203 } 199 }
204 void* parameter() const { 200 void* parameter() const {
205 DCHECK(IsInUse()); 201 DCHECK(IsInUse());
206 return parameter_or_next_free_.parameter; 202 return parameter_or_next_free_.parameter;
207 } 203 }
208 204
(...skipping 922 matching lines...) Expand 10 before | Expand all | Expand 10 after
1131 blocks_[block][offset] = object; 1127 blocks_[block][offset] = object;
1132 if (isolate->heap()->InNewSpace(object)) { 1128 if (isolate->heap()->InNewSpace(object)) {
1133 new_space_indices_.Add(size_); 1129 new_space_indices_.Add(size_);
1134 } 1130 }
1135 *index = size_++; 1131 *index = size_++;
1136 } 1132 }
1137 1133
1138 1134
1139 } // namespace internal 1135 } // namespace internal
1140 } // namespace v8 1136 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698