Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Unified Diff: include/v8-util.h

Issue 2741683004: [rename] Rename internal field to embedder field. (Closed)
Patch Set: DEPRECATE_SOON(GetInternalField) Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: include/v8-util.h
diff --git a/include/v8-util.h b/include/v8-util.h
index a04a5e84f80dc47e05cd65757e0fe0da1d80dbf5..8b73f1230cf373c86a745472576d0e28a4a6657d 100644
--- a/include/v8-util.h
+++ b/include/v8-util.h
@@ -25,11 +25,11 @@ enum PersistentContainerCallbackType {
kNotWeak,
// These correspond to v8::WeakCallbackType
kWeakWithParameter,
- kWeakWithInternalFields,
+ kWeakWithEmbedderFields,
+ kWeakWithInternalFields = kWeakWithEmbedderFields, // Deprecate.
kWeak = kWeakWithParameter // For backwards compatibility. Deprecate.
};
-
/**
* A default trait implemenation for PersistentValueMap which uses std::map
* as a backing map.
@@ -462,7 +462,7 @@ class GlobalValueMap : public PersistentValueMapBase<K, V, Traits> {
if (Traits::kCallbackType != kNotWeak) {
WeakCallbackType callback_type =
Traits::kCallbackType == kWeakWithInternalFields
- ? WeakCallbackType::kInternalFields
+ ? WeakCallbackType::kEmbedderFields
: WeakCallbackType::kParameter;
Local<V> value(Local<V>::New(this->isolate(), *persistent));
persistent->template SetWeak<typename Traits::WeakCallbackDataType>(
« include/v8-experimental.h ('K') | « include/v8-profiler.h ('k') | samples/process.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698