Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: include/v8-experimental.h

Issue 2741683004: [rename] Rename internal field to embedder field. (Closed)
Patch Set: DEPRECATE_SOON(GetInternalField) Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/v8.h ('k') | include/v8-profiler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8-experimental.h
diff --git a/include/v8-experimental.h b/include/v8-experimental.h
index 1773345e09add4d5bf774475e470dbde20f72b0c..4ddbcfbab554b7f927f3fe71988070fa6a7387d2 100644
--- a/include/v8-experimental.h
+++ b/include/v8-experimental.h
@@ -30,8 +30,12 @@ class V8_EXPORT FastAccessorBuilder {
ValueId IntegerConstant(int int_constant);
ValueId GetReceiver();
+ // TODO(v8): deprecate this in favor of LoadEmbedderField
vogelheim 2017/03/13 09:33:01 Maybe; TODO(vogelheim) (I need to either clean-up
ValueId LoadInternalField(ValueId value_id, int field_no);
+ // TODO(v8): deprecate this in favor of LoadEmbedderFieldUnchecked
ValueId LoadInternalFieldUnchecked(ValueId value_id, int field_no);
+ ValueId LoadEmbedderField(ValueId value_id, int field_no);
+ ValueId LoadEmbedderFieldUnchecked(ValueId value_id, int field_no);
ValueId LoadValue(ValueId value_id, int offset);
ValueId LoadObject(ValueId value_id, int offset);
ValueId ToSmi(ValueId value_id);
« no previous file with comments | « include/v8.h ('k') | include/v8-profiler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698