include/v8-profiler.h - Issue 2741683004: [rename] Rename internal field to embedder field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/v8-profiler.h

Issue 2741683004: [rename] Rename internal field to embedder field. (Closed)

Patch Set: DEPRECATE_SOON(GetInternalField) Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/v8-profiler.h

diff --git a/include/v8-profiler.h b/include/v8-profiler.h

index b60d137f4479e6eda65378809c51abb1d8810d75..bc3eba4bb84fa3d9e0e5e1474660ede55b1aff13 100644

--- a/include/v8-profiler.h

+++ b/include/v8-profiler.h

@@ -652,7 +652,7 @@ class V8_EXPORT HeapProfiler {

* Callback function invoked for obtaining RetainedObjectInfo for

* the given JavaScript wrapper object. It is prohibited to enter V8

* while the callback is running: only getters on the handle and

- * GetPointerFromInternalField on the objects are allowed.

+ * GetPointerFromExternalField on the objects are allowed.

typedef RetainedObjectInfo* (*WrapperInfoCallback)(uint16_t class_id,

Local<Value> wrapper);