Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 2741653003: [inspector] do not translate offset to line/column for coverage. (Closed)

Created:
3 years, 9 months ago by Yang
Modified:
3 years, 9 months ago
Reviewers:
caseq, pfeldman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] do not translate offset to line/column for coverage. R=caseq@chromium.org, pfeldman@chromium.org BUG=v8:5808 Review-Url: https://codereview.chromium.org/2741653003 Cr-Commit-Position: refs/heads/master@{#43710} Committed: https://chromium.googlesource.com/v8/v8/+/c827075993226826d173ad2b9fd4e2488efb3bcd

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -84 lines) Patch
M src/inspector/js_protocol.json View 1 chunk +0 lines, -4 lines 1 comment Download
M src/inspector/v8-profiler-agent-impl.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M test/inspector/cpu-profiler/coverage-expected.txt View 18 chunks +0 lines, -72 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yang
3 years, 9 months ago (2017-03-09 06:43:43 UTC) #1
caseq
lgtm
3 years, 9 months ago (2017-03-09 21:18:06 UTC) #2
pfeldman
https://codereview.chromium.org/2741653003/diff/1/src/inspector/js_protocol.json File src/inspector/js_protocol.json (left): https://codereview.chromium.org/2741653003/diff/1/src/inspector/js_protocol.json#oldcode851 src/inspector/js_protocol.json:851: { "name": "startLineNumber", "type": "integer", "description": "JavaScript script line ...
3 years, 9 months ago (2017-03-09 21:18:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741653003/1
3 years, 9 months ago (2017-03-10 04:51:40 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 05:19:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c827075993226826d173ad2b9fd4e2488ef...

Powered by Google App Engine
This is Rietveld 408576698