Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: src/inspector/v8-profiler-agent-impl.cc

Issue 2741653003: [inspector] do not translate offset to line/column for coverage. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/inspector/v8-profiler-agent-impl.cc
diff --git a/src/inspector/v8-profiler-agent-impl.cc b/src/inspector/v8-profiler-agent-impl.cc
index 5f5f815538169f061dbc45ef5fd08d15a94935c4..d57d37adebec8ffe0b6ebd666ba34d65f547f749 100644
--- a/src/inspector/v8-profiler-agent-impl.cc
+++ b/src/inspector/v8-profiler-agent-impl.cc
@@ -307,15 +307,7 @@ Response takeCoverage(
ranges = protocol::Array<protocol::Profiler::CoverageRange>::create();
// At this point we only have per-function coverage data, so there is
// only one range per function.
- v8::debug::Location start =
- script->GetSourceLocation(function_data.StartOffset());
- v8::debug::Location end =
- script->GetSourceLocation(function_data.EndOffset());
ranges->addItem(protocol::Profiler::CoverageRange::create()
- .setStartLineNumber(start.GetLineNumber())
- .setStartColumnNumber(start.GetColumnNumber())
- .setEndLineNumber(end.GetLineNumber())
- .setEndColumnNumber(end.GetColumnNumber())
.setStartOffset(function_data.StartOffset())
.setEndOffset(function_data.EndOffset())
.setCount(function_data.Count())

Powered by Google App Engine
This is Rietveld 408576698