Do not rely on code patching on DBC for lazy deoptimization.

Do not rely on code patching on DBC for lazy deoptimization.

Instead we now patch the return address, like the other architectures.

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/6efb75b22f60a1155f17e3f76e64f962f515710e

[turnidge, 2017-03-08 23:07:46]

turnidge@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2017-03-09 20:32:00]

lgtm

other platforms -> other architectures

https://codereview.chromium.org/2741553002/diff/20001/runtime/vm/code_patcher.h
File runtime/vm/code_patcher.h (left):

https://codereview.chromium.org/2741553002/diff/20001/runtime/vm/code_patcher...
runtime/vm/code_patcher.h:71: static void InsertDeoptimizationCallAt(uword
start);
Sweet!

https://codereview.chromium.org/2741553002/diff/20001/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/2741553002/diff/20001/runtime/vm/isolate.cc#n...
runtime/vm/isolate.cc:1956: if (fp == deopt_fp || IsCalleeFrameOf(fp, deopt_fp))
{
(fp == deopt_fp)

https://codereview.chromium.org/2741553002/diff/20001/runtime/vm/simulator_db...
File runtime/vm/simulator_dbc.cc (right):

https://codereview.chromium.org/2741553002/diff/20001/runtime/vm/simulator_db...
runtime/vm/simulator_dbc.cc:1096: pc = reinterpret_cast<uint32_t*>(fp_[2 -
kDartFrameFixedSize]);            \
kSavedCallerPcSlotFromFp

https://codereview.chromium.org/2741553002/diff/20001/runtime/vm/simulator_db...
runtime/vm/simulator_dbc.cc:1103: pc = reinterpret_cast<uint32_t*>(fp_[2 -
kDartFrameFixedSize]);            \
"

https://codereview.chromium.org/2741553002/diff/20001/runtime/vm/simulator_db...
runtime/vm/simulator_dbc.cc:1110: pc = reinterpret_cast<uint32_t*>(fp_[2 -
kDartFrameFixedSize]);            \
"

[turnidge, 2017-03-09 20:51:07]

Description was changed from

==========
Do not rely on code patching on DBC for lazy deoptimization.

Instead we now patch the return address, like the other platforms.
==========

to

==========
Do not rely on code patching on DBC for lazy deoptimization.

Instead we now patch the return address, like the other architectures.
==========

[turnidge, 2017-03-09 22:10:49]

Description was changed from

==========
Do not rely on code patching on DBC for lazy deoptimization.

Instead we now patch the return address, like the other architectures.
==========

to

==========
Do not rely on code patching on DBC for lazy deoptimization.

Instead we now patch the return address, like the other architectures.

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6efb75b22f60a1155f17e3f76e64f962f515710e
==========

[turnidge, 2017-03-09 22:10:51]

Committed patchset #3 (id:40001) manually as
6efb75b22f60a1155f17e3f76e64f962f515710e (presubmit successful).