runtime/vm/code_patcher_x64.cc - Issue 2741553002: Do not rely on code patching on DBC for lazy deoptimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/code_patcher_x64.cc

Issue 2741553002: Do not rely on code patching on DBC for lazy deoptimization. (Closed)

Patch Set: Code review Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/code_patcher_x64.cc

diff --git a/runtime/vm/code_patcher_x64.cc b/runtime/vm/code_patcher_x64.cc

index 4b79751b10b17ff1a9a3143ad5c349d8dd672b9a..aa1e6b8f17c4690bf6c5b42d1c50dd254c6da556 100644

--- a/runtime/vm/code_patcher_x64.cc

+++ b/runtime/vm/code_patcher_x64.cc

@@ -278,11 +278,6 @@ intptr_t CodePatcher::InstanceCallSizeInBytes() {

}

-void CodePatcher::InsertDeoptimizationCallAt(uword start) {

- UNREACHABLE();

RawFunction* CodePatcher::GetUnoptimizedStaticCallAt(uword return_address,

const Code& code,

ICData* ic_data_result) {

« no previous file with comments | « runtime/vm/code_patcher_mips.cc ('k') | runtime/vm/exceptions.cc » ('j') | no next file with comments »